-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EAM API: singular zone declarative app instance post API #316
base: main
Are you sure you want to change the base?
Conversation
bb8b16e
to
7ff5a15
Compare
The original definition of the API is designed to allow the consumer of the API This proposal is intended to allow the user of the /appinstances resource to request the deployment of the same applicationin different zones, with one single call. This proposal seem to modify that behaviour by only allowing the deployment of an application in one zone per single request. I think the original behaviour should stull be possible to simplify the user of the API, therefore I identify the following potential options to this
|
I have the same concern than @LuisVTazon commented, the idea is to make things easy to the use of the API, with this change we are obligating to the user to deploy these applications one by one per each zone. |
I'm not sure it would necessarily be easier. For example, if you are deploying through a web UI, the user will probably check a bunch of check boxes for which zones to deploy to, and then hit a deploy button. Whether the UI code runs one API call or many, the user doesn't actually know. In fact, individual calls may be better, in case some finish earlier than others, the user gets feedback sooner, rather than having to wait until all AppInstance requests are processed. How are you imagining these APIs will be used? Additionally, the DELETE API is for a single instance, so anyway DELETE must be managed one-by-one. It seems inconsistent that the API allows me to create many at once, but only delete one at a time. Why is this optimization necessary for create, but not for delete? If we have a multi-zone API call:
|
Hi @gainsley ,
|
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #256, #255
Special notes for reviewers:
Changelog input
Additional documentation