Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting code to idiomatic Python #1

Open
scardine opened this issue Aug 22, 2013 · 3 comments
Open

Converting code to idiomatic Python #1

scardine opened this issue Aug 22, 2013 · 3 comments

Comments

@scardine
Copy link

Nice work, man! I was looking for the quantization algorithm (Mike's source is way beyond my javascript wizardry level).

The code still smells like javascript. :-)

I want to help converting this to more idiomatic Python, can I send PR's?

@calvinmetcalf
Copy link
Owner

that would be extremely helpful I'm primarily a javascripter myself, hence how I was able to untangle the code. Also we need unit tests, what do the python kids use for that?

@calvinmetcalf
Copy link
Owner

fyi I've pushed to master since you forked it.

@scardine
Copy link
Author

Hi Calvin!

I'm writing tests with PyUnit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants