Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for about:blank pages #261

Open
cable729 opened this issue Oct 18, 2023 · 5 comments
Open

Add support for about:blank pages #261

cable729 opened this issue Oct 18, 2023 · 5 comments

Comments

@cable729
Copy link

I use an app that opens a file's content in a new "about:blank" page. Is it possible to support that use-case? From what I can tell, all that's needed is to add "match_about_blank": true to the manifest.json file.

@cable729
Copy link
Author

Hmm, I added this line and built and loaded the extension. It doesn't trigger the extension.

@cable729
Copy link
Author

I also added "about:blank" to the permissions in the manifest. Not working still.

@DarrenSem
Copy link

I use an app that opens a file's content in a new "about:blank" page. Is it possible to support that use-case? From what I can tell, all that's needed is to add "match_about_blank": true to the manifest.json file.

@cable729 I just found this extension, and looking at the "Issues" tab and found this -- I agree that your request to support about:blank dynamically-populated pages is very reasonable.
😟 I'm not sure how likely it is that you will get your Pull Request merged though: https://github.com/callumlocke/json-formatter/pulls

@callumlocke
Copy link
Owner

@cable729 Can you explain more about the use case? I don't understand. In what circumstances does about:blank show any content?

@DarrenSem
Copy link

@cable729 Can you explain more about the use case? I don't understand. In what circumstances does about:blank show any content?

I think he means (and I mean) when your JavaScript does something like...

var win = window.open("about:blank", "_blank");
 window.document.write("...contents that are JSON...");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants