Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding of generated CHANGELOG.md #38

Open
dornech opened this issue Dec 17, 2024 · 1 comment
Open

encoding of generated CHANGELOG.md #38

dornech opened this issue Dec 17, 2024 · 1 comment

Comments

@dornech
Copy link

dornech commented Dec 17, 2024

If I am not wrong, the encoding of a new changelog file on windows is set to windows-1252 but not UTF-8. What causes trouble.
@dornech
Copy link
Author

dornech commented Dec 17, 2024

I guess the issue is in generate_changelog/actions/file_processing.py in lines 50 and 93.
As utf-8 is expected, I guess it is reasonable to just add a kwarg encoding="utf-8".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dornech