Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pip env file; revert pipbuild env changes #689

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

brynpickering
Copy link
Member

Reverts changes in pipbuild made during the latest dev release (#681).

I've done this mostly because I get notifications that an action has failed with every PR, but it's just GitHub thinking the environment file is a workflow (since it's a YAML file inside the workflow directory).

Summary of changes in this pull request

Reviewer checklist

  • Test(s) added to cover contribution
  • Documentation updated
  • Changelog updated
  • Coverage maintained or improved

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.98%. Comparing base (e447d17) to head (6cd5d2f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #689   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files          26       26           
  Lines        3981     3981           
  Branches      837      768   -69     
=======================================
  Hits         3821     3821           
  Misses         70       70           
  Partials       90       90           

@brynpickering brynpickering merged commit c00486b into main Oct 8, 2024
12 checks passed
@brynpickering brynpickering deleted the fix-pip-ci branch October 8, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant