Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure project #488

Merged
merged 18 commits into from
Oct 23, 2023
Merged

Restructure project #488

merged 18 commits into from
Oct 23, 2023

Conversation

brynpickering
Copy link
Member

Summary of changes in this pull request:

  • Moving to using pyproject.toml as is the recommended way to define python project metadata now.
  • Move calliope into src to make sure tests are not getting confused about relative filepaths in a way we don't realise.
  • Move from azure pipelines to github actions, which allow us to leverage the growing number of pre-built actions (like micromamba for speedy env install).
  • Move tests out of the calliope package itself.
  • Move and restructure requirements files so that dev install becomes a much easier one-liner for the mamba/conda part.

Reviewer checklist:

  • Test(s) added to cover contribution
  • Documentation updated
  • Changelog updated
  • Coverage maintained or improved

Base automatically changed from cleanup to main October 23, 2023 12:24
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #488 (775dd6f) into main (cbed4c8) will decrease coverage by 3.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   94.98%   91.95%   -3.04%     
==========================================
  Files          31       31              
  Lines        3890     3890              
  Branches        0      923     +923     
==========================================
- Hits         3695     3577     -118     
  Misses        195      195              
- Partials        0      118     +118     
Files Coverage Δ
src/calliope/__init__.py 100.00% <ø> (ø)
src/calliope/_version.py 100.00% <ø> (ø)
src/calliope/backend/backends.py 96.38% <ø> (ø)
src/calliope/backend/expression_parser.py 94.80% <ø> (ø)
src/calliope/backend/helper_functions.py 99.35% <ø> (ø)
src/calliope/backend/latex_backend.py 95.52% <ø> (ø)
src/calliope/backend/parsing.py 99.51% <ø> (ø)
src/calliope/backend/where_parser.py 98.43% <ø> (ø)
src/calliope/cli.py 81.67% <ø> (ø)
src/calliope/core/__init__.py 100.00% <ø> (ø)
... and 21 more

sjpfenninger
sjpfenninger previously approved these changes Oct 23, 2023
Created by moving to src dir.
`calliope` is a regular dependency outside `src` files.
@brynpickering
Copy link
Member Author

Hoping that codecov will recover and realise the error of its ways once this is merged into main and new PRs build on top of it (I am at 94% coverage locally, not sure why it is at 92% here.

@brynpickering brynpickering merged commit 5591b09 into main Oct 23, 2023
10 of 11 checks passed
@brynpickering brynpickering deleted the restructure-project branch October 23, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants