[WIP] Search attributes db #5376
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dence-workflow#5340) * Validate search-attribute-key so keys are fine in advanced search ElasticSearch engine fails to parse keys with dashes, making those search-attributes broken for CLI and web. Validate search-attribute before creating on server so it looks like a valid variable name in most of languages, should be more than expected for programmers. The reason it is not in the server, is that currently even at Uber we have keys with dashes, and it will be a problem if we gonna migrate domains between clusters. * Return err to surface the expected search-attr format Otherwise it is not clear what the `--key` should be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes