Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cucumber expressions functionality #47

Open
tetiana12345678 opened this issue May 29, 2018 · 2 comments
Open

Add cucumber expressions functionality #47

tetiana12345678 opened this issue May 29, 2018 · 2 comments
Labels
1.0 enhancement Gherkin Suppot gherkin language features

Comments

@tetiana12345678
Copy link

tetiana12345678 commented May 29, 2018

Hello @mgwidmann !
I am wondering if there are plans to add cucumber expressions functionality, so we have something similar as described by Aslak here https://cucumber.io/blog/2017/07/26/announcing-cucumber-expressions

We are currently looking into it and I am wondering if you would accept a PR once we finished?

At the moment we are looking at features cucumber expressions provide, as described here https://docs.cucumber.io/cucumber/cucumber-expressions/
We are thinking at breaking that feature set into 3 features and deliver each in separate PR:

  1. support parameter types
  2. support optional text, alternative text, escaping
  3. support custom parameter types

To achieve that we are thinking of adding extra call to private find_implementation_of_step function, which would call CucumberExpressions module passing regex or string from step definition.
Here is where we would call our module from https://github.com/cabbage-ex/cabbage/blob/master/lib/cabbage/feature.ex#L240

How do you feel about that?

@hisapy
Copy link

hisapy commented May 31, 2018

This will be really interesting.

I had to do some tweaks to the generated Regex in some steps to have some sort of optional or alternative text and it will be really cool to have them auto-generated by Cabbage in my future projects.

@nicholasjhenry
Copy link
Collaborator

This was started here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 enhancement Gherkin Suppot gherkin language features
Projects
None yet
Development

No branches or pull requests

4 participants