-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pathways tab doesn't work in Safari #9093
Comments
@onursumer lets determine if this is on our end or pathways code |
A quick debug in Safari developer console shows that the problem is originated from this import statement: https://github.com/cBioPortal/cbioportal-frontend/blob/7d9adcc403e23c90872a26642fffdc5606e53d35/src/pages/resultsView/pathwayMapper/ResultsViewPathwayMapper.tsx#L77-L82 import(/* webpackChunkName: "pathway-mapper" */ 'pathway-mapper').then(
(module: any) => {
this.PathwayMapperComponent = (module as any)
.default as PathwayMapper;
}
); For some reason Safari may not be happy with this workaround. |
Looks like the actual problem is related to iVis-at-Bilkent/cytoscape.js-context-menus#55. We should fix it on the pathway mapper side. The issue is triggered by https://github.com/iVis-at-Bilkent/pathway-mapper/blob/88fd04112567fcfb072c337f277d21ae3ca8f61b/packages/pathway-mapper/src/managers/EditorActionsManager.tsx#L101. @Rgtemze suggests a workaround like this until there is a proper fix for iVis-at-Bilkent/cytoscape.js-context-menus#55: if (!isCBioPortal) {
this.edgeEditing = this.cy.edgeEditing(edgeEditingOptions);
} |
Nice find. Lets fix. |
http://www.cbioportal.org/patient/pathways?studyId=metastatic_solid_tumors_mich_2017&caseId=ES_5001
The text was updated successfully, but these errors were encountered: