Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patientview timeline track labels need truncation and tooltips #10448

Open
alisman opened this issue Oct 24, 2023 · 5 comments · May be fixed by cBioPortal/cbioportal-frontend#4990
Open

Patientview timeline track labels need truncation and tooltips #10448

alisman opened this issue Oct 24, 2023 · 5 comments · May be fixed by cBioPortal/cbioportal-frontend#4990
Labels
enhancement good first issue

Comments

@alisman
Copy link
Contributor

alisman commented Oct 24, 2023 •
edited
Loading

The track labels for the patient view timeline sometime need truncation. When they are too long, they should have elipsis treatment and a tooltip. There is already a component somewhere in the portal that does this. See if we can reuse that here.

Here is a patient view that has this problem on a couple tracks. However, there are much worse examples on private portals. So we need a general solution.
https://www.cbioportal.org/patient/summary?caseId=P04&studyId=lgg_ucsf_2014

image
@alisman alisman mentioned this issue Dec 27, 2023
Open
@shubhankarsharma876
Copy link

Sure I think I can fix this. And soon I will update the results. Thank you @alisman for updating me with this.

@shubhankarsharma876
Copy link

One last thing @alisman can you provide me the step guides to install the project in my system I tried myself but couldn't find it. And also installation got failed may be due to missing steps.
Also I read the readme of repository cBioPortal there it is mentioned that changes if needed only in frontend can be made directly to the cBioPortal-frontend repository. So should I make the changes in that repository.(This is silly question but asking for confirmation).

@sufiyan10-1
Copy link

@alisman same problem

@anantJjain anantJjain mentioned this issue Mar 3, 2024
Closed
@inodb
Copy link
Member

inodb commented Aug 16, 2024

@jCHENEBY will look at this CC @alisman

@Priyankagarai
Copy link

Could you please let me know if this issue is currently open or if it has already been addressed? If it is open, I would like to confirm the details and discuss how I can contribute to resolving it.

@jCHENEBY jCHENEBY linked a pull request Sep 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
5 participants
@alisman @inodb @shubhankarsharma876 @sufiyan10-1 @Priyankagarai