Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current version of Safari Mobile doesn't play well with TouchSwipe 1.6.3 #93

Open
jinglesthula opened this issue Aug 16, 2016 · 0 comments

Comments

@jinglesthula
Copy link

We're using jQuery UI 1.10.4 and the BYU template and accordion widgets don't open/close on iOS (9.3.2 is what I tested with on iPhone 6). After digging in I discovered the touch event was dying in the TouchSwipe plugin that's included in js/script-touch.min.js in the template. After swapping it out for the latest version of TouchSwipe the touch events began working. I'm assuming the plugin just never handled what I was testing, or that it worked one way with older versions of Safari Mobile back then and that Safari has changed since then. Either way, the plugin author appears to have taken steps to make it work on the current version.

For v3 of the template I'd suggest updating that (and all other plugins). And though this is off-topic for this issue, I'd recommend including the full bootstrap stylesheet (v4?). There were a number of things omitted that we needed, and keeping it intact will save people time hunting things down when they realize bits are missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant