Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmtime-py 13.0.0, 13.0.1 breaks compatibility with Python 3.7, 3.8, 3.9 #189

Closed
whitequark opened this issue Sep 21, 2023 · 11 comments
Closed

Comments

@whitequark
Copy link
Contributor

See these failing jobs: https://github.com/YoWASP/runtime/actions/runs/6255807281/job/16985710642

Not sure if this was intended? README still advertises compatibility with Python 3.6.

@thewtex
Copy link
Contributor

thewtex commented Sep 21, 2023

thewtex added a commit to thewtex/ITK-Wasm that referenced this issue Sep 21, 2023
thewtex added a commit to thewtex/ITK-Wasm that referenced this issue Sep 21, 2023
thewtex added a commit to thewtex/wasmtime-py that referenced this issue Sep 21, 2023
@thewtex
Copy link
Contributor

thewtex commented Sep 21, 2023

Proposed patch in #190

wasmtime-py 14

I think wasmtime-py 13 was meant.

thewtex added a commit to thewtex/ITK-Wasm that referenced this issue Sep 21, 2023
alexcrichton pushed a commit that referenced this issue Sep 21, 2023
@alexcrichton
Copy link
Member

Ok Wasmtime 13.0.1 is now published, but let me know if that's still broken!

@whitequark
Copy link
Contributor Author

@alexcrichton Nope, still failing: https://github.com/YoWASP/runtime/actions/runs/6268809144/job/17024332491

I feel like the wasmtime-py project ought to run CI on the Python versions it claims to support.

@whitequark whitequark changed the title wasmtime-py 14 breaks compatibility with Python 3.7, 3.8 wasmtime-py 13.0.0, 13.0.1 breaks compatibility with Python 3.7, 3.8, 3.9 Sep 22, 2023
@whitequark
Copy link
Contributor Author

I've also updated the title to be a bit more precise.

@alexcrichton
Copy link
Member

I'm no Python expert myself so you can see me flailing around on #192 trying to get something working. Right now I'm at the point where Protocol doesn't exist in 3.7. I'm not sure if there are more issues but it's as far as I've gotten.

Protocol is used by generated bindings for the component model, so it wasn't broken in the last release or anything like that. I think I may have fixed the issues that broke compat in the last release. Does anyone know how to only run a subset of tests on Python 3.8+? Ideally the codegen tests would all be disabled in 3.7 to sidestep the Protocol issue.

Apparently GitHub actions doesn't have Python 3.6 for the Ubuntu 22.04 image so I chose 3.7 as the minimum version.

@whitequark
Copy link
Contributor Author

Does anyone know how to only run a subset of tests on Python 3.8+? Ideally the codegen tests would all be disabled in 3.7 to sidestep the Protocol issue.

This maybe?

Apparently GitHub actions doesn't have Python 3.6 for the Ubuntu 22.04 image so I chose 3.7 as the minimum version.

No problem for me; I'll bump up the YoWASP runtime version then.

@alexcrichton
Copy link
Member

Hm I realize now that this is not only in tests but also the wasmtime.bindgen module which I don't necessarily know how to prevent pytest from loading for just 3.7. Given this run though it looks like 3.8 passes tests.

@whitequark is it a problem if the minimum version is raised to 3.8?

@whitequark
Copy link
Contributor Author

I think that's fine; Python 3.7 will reach end of life in October anyway.

@alexcrichton
Copy link
Member

Ok cool, with CI now in place #192 I think fixes this and I'll publish as 13.0.2 in #193

@whitequark
Copy link
Contributor Author

Thanks! I've published an updated YoWASP runtime, it passes tests fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants