Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results should not lead to (more) tabs that do not match what's sought #1094

Open
grahamperrin opened this issue May 27, 2017 · 4 comments

Comments

@grahamperrin
Copy link

It makes no sense to show:

n more tabs…

– when none matches what's sought.

Re: #437 Esc escaping does now clear the search field, so I can't think of a good reason to offer to show more non-matching tabs in the context of search results.

@SoftVision-CiprianMuresan
Copy link
Collaborator

Hi @grahamperrin, thanks for the report.
The title of the issue sounds a lot like #1004. But the contents of the issue refer to the "n more tabs".

Is the issue about:

  1. Tabs that are not filtered correctly?
    OR
  2. Showing "n more tabs" when no tabs match the filter?

@grahamperrin
Copy link
Author

Thanks for asking. It's close to (2).

Showing 'n more tabs' when some tabs, or no tabs, match.

@ericawright
Copy link
Collaborator

thanks for the report grahamperrin, the "n more tabs..." button is so that the searcher has an easy way to get back to their tab list if they do not find what they are searching for. That way people don't lose the tabs, or think we have closed them.

@grahamperrin
Copy link
Author

It's peculiar.

A less peculiar approach might be something like a Clear icon in the search field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants