diff --git a/Client/src/js/bcdui.js b/Client/src/js/bcdui.js index 4401bf3b..6814f83e 100644 --- a/Client/src/js/bcdui.js +++ b/Client/src/js/bcdui.js @@ -266,8 +266,7 @@ jQuery.extend( bcdui, * @private */ BCDAppender.prototype._getDetailMessage = function() { - var msg = bcdui.config.sessionId; - msg += "\n" + new Date().toISOString(); + var msg = "\n" + new Date().toISOString(); msg += "\n" + navigator.userAgent; msg += "\n\n" + location.href; msg += "\n\n" + this.bufferedMessage; diff --git a/Server/src/main/java/de/businesscode/bcdui/web/accessLogging/RequestHashGenerator.java b/Server/src/main/java/de/businesscode/bcdui/web/accessLogging/RequestHashGenerator.java index 529a8a3f..889cd2e5 100644 --- a/Server/src/main/java/de/businesscode/bcdui/web/accessLogging/RequestHashGenerator.java +++ b/Server/src/main/java/de/businesscode/bcdui/web/accessLogging/RequestHashGenerator.java @@ -31,7 +31,7 @@ public static String generateHash(HttpServletRequest request) { String addOn = request.getSession(false) != null ? request.getSession(false).getId() : "-"; String url = request.getHeader("Referer"); if (url == null) - return addOn; + return new Integer(addOn.hashCode()).toString(); // Here we avoid sharing sessionid information with the client int x = url.indexOf("//"); url = x != -1 ? url.substring(x + 2) : url; int y = url.indexOf("/"); diff --git a/Server/src/main/java/de/businesscode/bcdui/web/servlets/BCDUIConfig.java b/Server/src/main/java/de/businesscode/bcdui/web/servlets/BCDUIConfig.java index b1cda28e..a1f80022 100644 --- a/Server/src/main/java/de/businesscode/bcdui/web/servlets/BCDUIConfig.java +++ b/Server/src/main/java/de/businesscode/bcdui/web/servlets/BCDUIConfig.java @@ -73,7 +73,6 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response) t properties.load(new FileInputStream(propFile)); boolean isDebug = ServletUtils.getInstance().isFeDebug(request); - String sessionId = (request != null && request.getSession(false) != null ? request.getSession(false).getId() : ""); PrintWriter writer = new PrintWriter(response.getWriter()); writer.println("var bcdui = bcdui || {};"); @@ -81,8 +80,6 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response) t writer.println("bcdui.config = {"); writeClientParams(writer); writer.println(" contextPath: \"" + getServletContext().getContextPath() + "\""); - // FIXME TODO drop sessionId from here and use sessionHash where appropriate. - writer.println(" , sessionId: \"" + sessionId + "\""); // write authenticate information try { @@ -167,6 +164,7 @@ else if (!lastRight.equals(right)) { if( ! "true".equals( request.getParameter("bcduiConfigOnly") ) ) writer.println("document.write(\"\");"); + String sessionId = (request != null && request.getSession(false) != null ? request.getSession(false).getId() : ""); if( log.isDebugEnabled() ) log.debug("PageHash "+pageHash+" for "+request.getHeader("Referer")+", "+sessionId);