-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This fix should be reconsidered. #13
Comments
The same style exists for |
Hey jinzhe, do you think a reasonable fix would be to z-index select elements above everything else? |
I think the best way is to remove the I've remove it in my fork but since you had a note there as "// Fix the border disappearing bug in Chrome" so thought i'd ask first before making a pull request. Do you remember how to recreate this bug in the comment? |
I believe that bug can be recreated by resizing the browser window. When it hits certain widths a 1px border disappears. |
formalism/fieldset/base.scss
Line 33 in a10e70a
This fix is creating a local stacking context for each field based on their order in the DOM. And this will cause an issue in the following scenario:
Both
.select
and.textarea
is using some custom components (not native formalism). They all have some kind ofz-index
defined in them.If select list is too long, the
z-index
attribute of the list won't work due to the ancestor's(.field-set__inner
) local stacking context and will always show behind the.textarea
I noticed that this
transform
was introduced to solve an browser issue, wonder if there is another solution?The text was updated successfully, but these errors were encountered: