Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paging not working as expected #316

Open
NordicLight opened this issue Oct 21, 2023 · 5 comments
Open

Paging not working as expected #316

NordicLight opened this issue Oct 21, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@NordicLight
Copy link

NordicLight commented Oct 21, 2023

Describe the bug
We updated from 2.7.0 to 3.1.1 and paging not working as expected. We do not expect the right most node to be visible in the org chart (see picture below)

To Reproduce
//We added the three page config items per your example
Screenshot 2023-10-21 at 15 22 54

//We are not adding the _paging properties
Screenshot 2023-10-21 at 15 22 22

Expected behavior
We do not expect the right most node to be visible in the picture

Screenshots
Screenshot 2023-10-21 at 15 13 06

Desktop (please complete the following information):
Chrome latest

Additional context
Add any other context about the problem here.

@bumbeishvili
Copy link
Owner

@NordicLight not exactly sure what's happening

Can you fork this sample and reproduce the issue here?

https://stackblitz.com/edit/js-pr15gr?file=index.html

@NordicLight
Copy link
Author

@NordicLight
Copy link
Author

Did you find the bug with the example?

@bumbeishvili bumbeishvili added the bug Something isn't working label Oct 30, 2023
@bumbeishvili
Copy link
Owner

bumbeishvili commented Oct 30, 2023

@NordicLight yes I did find it.

Not sure why is happening, I'll give it a look once I find a time (no promises around timeline)

@iae1
Copy link

iae1 commented Mar 11, 2024

Hey guys, I believe that the issue is that on line 1470 when filtering you don't check to see if hiddenNodesMap[d.nodeId] !== true in addition to checking if hiddenNodesMap[d.id] !== true. Updating that line should solve it. I just made a PR #367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants