From ce71e33d6ce1ca36191ae4ea3a60f8c88559c402 Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Wed, 8 Dec 2021 00:28:13 -0500 Subject: [PATCH 01/43] add regression test for tutorials --- .../workflows/tutorials_regression_test.yml | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 .github/workflows/tutorials_regression_test.yml diff --git a/.github/workflows/tutorials_regression_test.yml b/.github/workflows/tutorials_regression_test.yml new file mode 100644 index 000000000..d1923d38f --- /dev/null +++ b/.github/workflows/tutorials_regression_test.yml @@ -0,0 +1,23 @@ +name: Regression Test in Container + +on: + pull_request: + branches: [ devel ] + +buildtest_tutorial_container: + needs: build_container + runs-on: ubuntu-latest + container: + image: ghcr.io/buildtesters/buildtest_spack + steps: + - name: debug in container + run: | + which git + git --version + - uses: actions/checkout@v2 + - name: regression test in container + run: | + cd $GITHUB_WORKSPACE + ls -la $GITHUB_WORKSPACE + ls -la $HOME + bash buildtest/scripts/spack_container/regtest-tutorial.sh \ No newline at end of file From e2769e1516e81d210ba03dd2206091646ed8baa7 Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Wed, 8 Dec 2021 00:30:08 -0500 Subject: [PATCH 02/43] error in workflow. Missing 'jobs' keyword --- .github/workflows/tutorials_regression_test.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tutorials_regression_test.yml b/.github/workflows/tutorials_regression_test.yml index d1923d38f..2a0962a98 100644 --- a/.github/workflows/tutorials_regression_test.yml +++ b/.github/workflows/tutorials_regression_test.yml @@ -4,7 +4,8 @@ on: pull_request: branches: [ devel ] -buildtest_tutorial_container: +jobs: + buildtest_tutorial_container: needs: build_container runs-on: ubuntu-latest container: From 36543640084828e12128cf103f691b4d184c315a Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Wed, 8 Dec 2021 00:32:14 -0500 Subject: [PATCH 03/43] remove keyword 'needs' this was error due to copy/paste since we don't need dependency when running this job --- .github/workflows/tutorials_regression_test.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/tutorials_regression_test.yml b/.github/workflows/tutorials_regression_test.yml index 2a0962a98..af2463cc1 100644 --- a/.github/workflows/tutorials_regression_test.yml +++ b/.github/workflows/tutorials_regression_test.yml @@ -6,7 +6,6 @@ on: jobs: buildtest_tutorial_container: - needs: build_container runs-on: ubuntu-latest container: image: ghcr.io/buildtesters/buildtest_spack From 141cbf4b6cf42bd2af01863844a04e5f6f5aa562 Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Fri, 29 Sep 2023 11:29:31 -0400 Subject: [PATCH 04/43] adding regression test workflow in container --- .../workflows/regressiontest_container.yml | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 .github/workflows/regressiontest_container.yml diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml new file mode 100644 index 000000000..64f885a11 --- /dev/null +++ b/.github/workflows/regressiontest_container.yml @@ -0,0 +1,38 @@ +name: Regression Test in Container + +on: + pull_request: + branches: [ devel ] + + buildtest_tutorial_container: + needs: build_container + runs-on: ubuntu-latest + container: + image: ghcr.io/buildtesters/buildtest_spack + options: "-it" + steps: + - name: debug in container + run: | + env + whoami + id + which git + git --version + ls -la $HOME + echo $HOME + shopt -q login_shell && echo 'Login shell' || echo 'Not login shell' + - uses: actions/checkout@v2 + - name: regression test in container + run: | + which git + git --version + env + cd $GITHUB_WORKSPACE + ls -la $GITHUB_WORKSPACE + ls -la $HOME + . buildtest/scripts/spack_container/setup.sh + module avail + git log HEAD + python $BUILDTEST_ROOT/buildtest/tools/unittests.py -c + returncode=$? + if [ $returncode != 0 ]; then exit $returncode; fi \ No newline at end of file From 0c5a90f41568ded023ffe532b4afed8e7495ebdd Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Fri, 29 Sep 2023 11:31:41 -0400 Subject: [PATCH 05/43] fix typo in github workflow --- .github/workflows/regressiontest_container.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 64f885a11..529a7382f 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -3,9 +3,9 @@ name: Regression Test in Container on: pull_request: branches: [ devel ] - + +jobs: buildtest_tutorial_container: - needs: build_container runs-on: ubuntu-latest container: image: ghcr.io/buildtesters/buildtest_spack @@ -35,4 +35,4 @@ on: git log HEAD python $BUILDTEST_ROOT/buildtest/tools/unittests.py -c returncode=$? - if [ $returncode != 0 ]; then exit $returncode; fi \ No newline at end of file + if [ $returncode != 0 ]; then exit $returncode; fi From 2d61c620fda37cd50b4d97939de226c7a96a29e1 Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Fri, 29 Sep 2023 11:42:45 -0400 Subject: [PATCH 06/43] debug workflow --- .github/workflows/regressiontest_container.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 529a7382f..428023677 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -9,8 +9,9 @@ jobs: runs-on: ubuntu-latest container: image: ghcr.io/buildtesters/buildtest_spack - options: "-it" + options: "-it --user spack" steps: + - uses: actions/checkout@v2 - name: debug in container run: | env @@ -20,8 +21,8 @@ jobs: git --version ls -la $HOME echo $HOME - shopt -q login_shell && echo 'Login shell' || echo 'Not login shell' - - uses: actions/checkout@v2 + module --version + module avail - name: regression test in container run: | which git From 7d2526e8133d2494b9bb61573a68f2f113cd4aa1 Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Fri, 29 Sep 2023 11:46:39 -0400 Subject: [PATCH 07/43] try using root user in container --- .github/workflows/regressiontest_container.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 428023677..3c8ac9818 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -9,7 +9,7 @@ jobs: runs-on: ubuntu-latest container: image: ghcr.io/buildtesters/buildtest_spack - options: "-it --user spack" + options: "-it --user root" steps: - uses: actions/checkout@v2 - name: debug in container From a3329f711a94af825ff8c4d5be809abd8ea43092 Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Fri, 29 Sep 2023 11:53:41 -0400 Subject: [PATCH 08/43] debug workflow --- .../workflows/regressiontest_container.yml | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 3c8ac9818..4ecfd8690 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -12,28 +12,19 @@ jobs: options: "-it --user root" steps: - uses: actions/checkout@v2 - - name: debug in container + - name: regression test in container run: | env whoami - id - which git - git --version + id ls -la $HOME echo $HOME - module --version - module avail - - name: regression test in container - run: | - which git - git --version - env cd $GITHUB_WORKSPACE ls -la $GITHUB_WORKSPACE - ls -la $HOME - . buildtest/scripts/spack_container/setup.sh + source /etc/profile + module --version module avail - git log HEAD + . buildtest/scripts/spack_container/setup.sh python $BUILDTEST_ROOT/buildtest/tools/unittests.py -c returncode=$? if [ $returncode != 0 ]; then exit $returncode; fi From 4a54f644ae8f51e985e5b40b0b2661c963a01d01 Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Fri, 29 Sep 2023 12:07:01 -0400 Subject: [PATCH 09/43] debug workflow --- .github/workflows/regressiontest_container.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 4ecfd8690..b8e6213cf 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -16,12 +16,14 @@ jobs: run: | env whoami + echo $SHELL id ls -la $HOME echo $HOME cd $GITHUB_WORKSPACE ls -la $GITHUB_WORKSPACE - source /etc/profile + set +e + . /etc/profile module --version module avail . buildtest/scripts/spack_container/setup.sh From 9a1dd867826df15b8ecaffdd490b8a489d36abb0 Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Fri, 29 Sep 2023 12:13:38 -0400 Subject: [PATCH 10/43] bump version of checkout to v3 --- .github/workflows/regressiontest_container.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index b8e6213cf..4b4faa904 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -11,12 +11,11 @@ jobs: image: ghcr.io/buildtesters/buildtest_spack options: "-it --user root" steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: regression test in container run: | env whoami - echo $SHELL id ls -la $HOME echo $HOME @@ -26,7 +25,8 @@ jobs: . /etc/profile module --version module avail - . buildtest/scripts/spack_container/setup.sh + spack --version + . scripts/spack_container/setup.sh python $BUILDTEST_ROOT/buildtest/tools/unittests.py -c returncode=$? if [ $returncode != 0 ]; then exit $returncode; fi From facd1bae622d5fb70aedabaf0e9b7bd11dbaac2a Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Fri, 29 Sep 2023 12:22:17 -0400 Subject: [PATCH 11/43] debug workflow --- .github/workflows/regressiontest_container.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 4b4faa904..18bd15f98 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -21,12 +21,17 @@ jobs: echo $HOME cd $GITHUB_WORKSPACE ls -la $GITHUB_WORKSPACE - set +e + set +xe . /etc/profile module --version module avail spack --version - . scripts/spack_container/setup.sh + module load python + python -m venv "$HOME/pyenv/buildtest" + . "$HOME/pyenv/buildtest/bin/activate" + . setup.sh + export BUILDTEST_CONFIGFILE=$BUILDTEST_ROOT/buildtest/settings/spack_container.yml + python $BUILDTEST_ROOT/buildtest/tools/unittests.py -c returncode=$? if [ $returncode != 0 ]; then exit $returncode; fi From 4495c925c9e615acd245e3f8b04a2d9007fdac84 Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Fri, 29 Sep 2023 12:22:36 -0400 Subject: [PATCH 12/43] remove --user root --- .github/workflows/regressiontest_container.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 18bd15f98..cde62ce83 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -9,7 +9,7 @@ jobs: runs-on: ubuntu-latest container: image: ghcr.io/buildtesters/buildtest_spack - options: "-it --user root" + options: "-it" steps: - uses: actions/checkout@v3 - name: regression test in container From 077924d056ffb7fb8bad835e6eaab97a63215ab6 Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Fri, 29 Sep 2023 12:44:26 -0400 Subject: [PATCH 13/43] add root user back --- .github/workflows/regressiontest_container.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index cde62ce83..18bd15f98 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -9,7 +9,7 @@ jobs: runs-on: ubuntu-latest container: image: ghcr.io/buildtesters/buildtest_spack - options: "-it" + options: "-it --user root" steps: - uses: actions/checkout@v3 - name: regression test in container From a7312b30e5b283cb62c65e3a909e76e913eedfb2 Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Fri, 29 Sep 2023 14:39:24 -0400 Subject: [PATCH 14/43] debug workflow --- .github/workflows/regressiontest_container.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 18bd15f98..cde62ce83 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -9,7 +9,7 @@ jobs: runs-on: ubuntu-latest container: image: ghcr.io/buildtesters/buildtest_spack - options: "-it --user root" + options: "-it" steps: - uses: actions/checkout@v3 - name: regression test in container From 8e5a6090e137ffc6dc38bd2533feddb18986e027 Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Fri, 29 Sep 2023 14:45:06 -0400 Subject: [PATCH 15/43] add --user spack --- .github/workflows/regressiontest_container.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index cde62ce83..545bec506 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -9,7 +9,7 @@ jobs: runs-on: ubuntu-latest container: image: ghcr.io/buildtesters/buildtest_spack - options: "-it" + options: "-it --user spack" steps: - uses: actions/checkout@v3 - name: regression test in container From ecf4d4c154548f759dd522d4902bda4a3290eda0 Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Fri, 29 Sep 2023 14:58:31 -0400 Subject: [PATCH 16/43] debug workflow --- .github/workflows/regressiontest_container.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 545bec506..4a5a11143 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -11,6 +11,10 @@ jobs: image: ghcr.io/buildtesters/buildtest_spack options: "-it --user spack" steps: + - name: Chown user + run: | + sudo chown -R $USER:$USER $GITHUB_WORKSPACE + ls -la $GITHUB_WORKSPACE - uses: actions/checkout@v3 - name: regression test in container run: | From 6f278c65d23f05b69542528b4a3ed5d157d9b8fe Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Fri, 29 Sep 2023 15:05:22 -0400 Subject: [PATCH 17/43] remove checkout step --- .github/workflows/regressiontest_container.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 4a5a11143..cd691d512 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -11,11 +11,6 @@ jobs: image: ghcr.io/buildtesters/buildtest_spack options: "-it --user spack" steps: - - name: Chown user - run: | - sudo chown -R $USER:$USER $GITHUB_WORKSPACE - ls -la $GITHUB_WORKSPACE - - uses: actions/checkout@v3 - name: regression test in container run: | env From cefc0a7b8f492f42f94f5b132576d706aacc065e Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Fri, 29 Sep 2023 16:30:14 -0400 Subject: [PATCH 18/43] debug workflow --- .github/workflows/regressiontest_container.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index cd691d512..0498c9e8a 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -12,6 +12,7 @@ jobs: options: "-it --user spack" steps: - name: regression test in container + shell: bash run: | env whoami @@ -26,11 +27,10 @@ jobs: module avail spack --version module load python - python -m venv "$HOME/pyenv/buildtest" - . "$HOME/pyenv/buildtest/bin/activate" + python -m venv /home/spack/pyenv/buildtest + . /home/spack/pyenv/buildtest/bin/activate" . setup.sh export BUILDTEST_CONFIGFILE=$BUILDTEST_ROOT/buildtest/settings/spack_container.yml - python $BUILDTEST_ROOT/buildtest/tools/unittests.py -c returncode=$? if [ $returncode != 0 ]; then exit $returncode; fi From 2522d1f329c20cf09bcb7bec60243e64c87d2881 Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Tue, 14 Nov 2023 17:34:23 -0700 Subject: [PATCH 19/43] change directory path where virtual environment is created --- .github/workflows/regressiontest_container.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 0498c9e8a..336f9aade 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -27,8 +27,8 @@ jobs: module avail spack --version module load python - python -m venv /home/spack/pyenv/buildtest - . /home/spack/pyenv/buildtest/bin/activate" + python -m venv ~/pyenv/buildtest + . ~/pyenv/buildtest/bin/activate" . setup.sh export BUILDTEST_CONFIGFILE=$BUILDTEST_ROOT/buildtest/settings/spack_container.yml python $BUILDTEST_ROOT/buildtest/tools/unittests.py -c From 24763368994e9fa3c07b514900b4100787db93ba Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Tue, 14 Nov 2023 17:41:56 -0700 Subject: [PATCH 20/43] debug workflow and remove workflow --- .../workflows/regressiontest_container.yml | 6 +++++ .../workflows/tutorials_regression_test.yml | 23 ------------------- 2 files changed, 6 insertions(+), 23 deletions(-) delete mode 100644 .github/workflows/tutorials_regression_test.yml diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 336f9aade..5739e988a 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -27,6 +27,7 @@ jobs: module avail spack --version module load python + mkdir -p ~/pyenv/buildtest python -m venv ~/pyenv/buildtest . ~/pyenv/buildtest/bin/activate" . setup.sh @@ -34,3 +35,8 @@ jobs: python $BUILDTEST_ROOT/buildtest/tools/unittests.py -c returncode=$? if [ $returncode != 0 ]; then exit $returncode; fi + + - name: Setup tmate session + if: ${{ failure() }} + uses: mxschmitt/action-tmate@v3 + timeout-minutes: 30 \ No newline at end of file diff --git a/.github/workflows/tutorials_regression_test.yml b/.github/workflows/tutorials_regression_test.yml deleted file mode 100644 index af2463cc1..000000000 --- a/.github/workflows/tutorials_regression_test.yml +++ /dev/null @@ -1,23 +0,0 @@ -name: Regression Test in Container - -on: - pull_request: - branches: [ devel ] - -jobs: - buildtest_tutorial_container: - runs-on: ubuntu-latest - container: - image: ghcr.io/buildtesters/buildtest_spack - steps: - - name: debug in container - run: | - which git - git --version - - uses: actions/checkout@v2 - - name: regression test in container - run: | - cd $GITHUB_WORKSPACE - ls -la $GITHUB_WORKSPACE - ls -la $HOME - bash buildtest/scripts/spack_container/regtest-tutorial.sh \ No newline at end of file From 697765fa7f160be159b2a07a653f38ccf0f699ab Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Tue, 14 Nov 2023 17:49:13 -0700 Subject: [PATCH 21/43] debug workflow --- .github/workflows/regressiontest_container.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 5739e988a..61543e1c1 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -27,9 +27,9 @@ jobs: module avail spack --version module load python - mkdir -p ~/pyenv/buildtest - python -m venv ~/pyenv/buildtest - . ~/pyenv/buildtest/bin/activate" + mkdir -p /tmp/pyenv + python -m venv /tmp/pyenv/buildtest + . /tmp/pyenv/buildtest/bin/activate" . setup.sh export BUILDTEST_CONFIGFILE=$BUILDTEST_ROOT/buildtest/settings/spack_container.yml python $BUILDTEST_ROOT/buildtest/tools/unittests.py -c From 93d2949b430d902c8d80b57596705ace9fd6eed9 Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Tue, 14 Nov 2023 18:01:17 -0700 Subject: [PATCH 22/43] debug workflow --- .github/workflows/regressiontest_container.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 61543e1c1..de826a4c5 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -9,7 +9,7 @@ jobs: runs-on: ubuntu-latest container: image: ghcr.io/buildtesters/buildtest_spack - options: "-it --user spack" + options: "-it --user spack -e 'HOME=/home/spack'" steps: - name: regression test in container shell: bash @@ -17,7 +17,7 @@ jobs: env whoami id - ls -la $HOME + ls -ld $HOME echo $HOME cd $GITHUB_WORKSPACE ls -la $GITHUB_WORKSPACE @@ -27,9 +27,9 @@ jobs: module avail spack --version module load python - mkdir -p /tmp/pyenv - python -m venv /tmp/pyenv/buildtest - . /tmp/pyenv/buildtest/bin/activate" + #mkdir -p /tmp/pyenv + #python -m venv /tmp/pyenv/buildtest + #. /tmp/pyenv/buildtest/bin/activate" . setup.sh export BUILDTEST_CONFIGFILE=$BUILDTEST_ROOT/buildtest/settings/spack_container.yml python $BUILDTEST_ROOT/buildtest/tools/unittests.py -c From 58b33c3c68ff46afdb4a82b63fa97b2b159ce1ef Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Tue, 14 Nov 2023 18:10:19 -0700 Subject: [PATCH 23/43] debug --- .github/workflows/regressiontest_container.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index de826a4c5..d2919e5f1 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -9,7 +9,7 @@ jobs: runs-on: ubuntu-latest container: image: ghcr.io/buildtesters/buildtest_spack - options: "-it --user spack -e 'HOME=/home/spack'" + options: "-it --user spack" steps: - name: regression test in container shell: bash @@ -30,6 +30,7 @@ jobs: #mkdir -p /tmp/pyenv #python -m venv /tmp/pyenv/buildtest #. /tmp/pyenv/buildtest/bin/activate" + cd $GITHUB_WORKSPACE . setup.sh export BUILDTEST_CONFIGFILE=$BUILDTEST_ROOT/buildtest/settings/spack_container.yml python $BUILDTEST_ROOT/buildtest/tools/unittests.py -c From 9d7d9c579fbd53ac35118386fd4ccfffac5ff330 Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Tue, 14 Nov 2023 18:16:53 -0700 Subject: [PATCH 24/43] debug --- .github/workflows/regressiontest_container.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index d2919e5f1..60ebd34cc 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -27,10 +27,11 @@ jobs: module avail spack --version module load python - #mkdir -p /tmp/pyenv - #python -m venv /tmp/pyenv/buildtest - #. /tmp/pyenv/buildtest/bin/activate" + which python3 + python3 --version3 cd $GITHUB_WORKSPACE + pwd + ls -la . setup.sh export BUILDTEST_CONFIGFILE=$BUILDTEST_ROOT/buildtest/settings/spack_container.yml python $BUILDTEST_ROOT/buildtest/tools/unittests.py -c From 5f912a91d9e603ae0a4d70c51b94a315e09e6678 Mon Sep 17 00:00:00 2001 From: Sijie Date: Fri, 14 Jun 2024 07:47:40 -0700 Subject: [PATCH 25/43] check pwd --- .../workflows/regressiontest_container.yml | 36 ++++++++++--------- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 60ebd34cc..89884ce3a 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -14,24 +14,26 @@ jobs: - name: regression test in container shell: bash run: | - env - whoami - id - ls -ld $HOME - echo $HOME - cd $GITHUB_WORKSPACE - ls -la $GITHUB_WORKSPACE - set +xe - . /etc/profile - module --version - module avail - spack --version + # env + # whoami + # id + # ls -ld $HOME + # echo $HOME + # cd $GITHUB_WORKSPACE + # ls -la $GITHUB_WORKSPACE + # set +xe + # . /etc/profile + # module --version + # module avail + # spack --version module load python - which python3 - python3 --version3 - cd $GITHUB_WORKSPACE - pwd - ls -la + # which python3 + # python3 --version3 + # cd $GITHUB_WORKSPACE + # ls -la + export HOMEDIR=`pwd` + echo $HOMEDIR + . setup.sh export BUILDTEST_CONFIGFILE=$BUILDTEST_ROOT/buildtest/settings/spack_container.yml python $BUILDTEST_ROOT/buildtest/tools/unittests.py -c From db44cd6bb6f71f1f217a283d36ed0bb5362d695e Mon Sep 17 00:00:00 2001 From: Sijie Date: Fri, 14 Jun 2024 07:53:18 -0700 Subject: [PATCH 26/43] try to fix module command --- .github/workflows/regressiontest_container.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 89884ce3a..fccfb8f26 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -21,8 +21,8 @@ jobs: # echo $HOME # cd $GITHUB_WORKSPACE # ls -la $GITHUB_WORKSPACE - # set +xe - # . /etc/profile + set +xe + . /etc/profile # module --version # module avail # spack --version From bae652a9c48da3ae4e068174a6ca63fc95ce3fa6 Mon Sep 17 00:00:00 2001 From: Sijie Date: Fri, 14 Jun 2024 08:01:52 -0700 Subject: [PATCH 27/43] display homedir --- .github/workflows/regressiontest_container.yml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index fccfb8f26..73d3cf90f 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -27,16 +27,20 @@ jobs: # module avail # spack --version module load python - # which python3 + which python3 # python3 --version3 # cd $GITHUB_WORKSPACE # ls -la export HOMEDIR=`pwd` echo $HOMEDIR + echo "-------------" + ls -la $HOMEDIR + echo "-------------" + . setup.sh - export BUILDTEST_CONFIGFILE=$BUILDTEST_ROOT/buildtest/settings/spack_container.yml - python $BUILDTEST_ROOT/buildtest/tools/unittests.py -c + export BUILDTEST_CONFIGFILE=$HOMEDIR/buildtest/settings/spack_container.yml + python $HOMEDIR/buildtest/tools/unittests.py -c returncode=$? if [ $returncode != 0 ]; then exit $returncode; fi From 70de04318b82932ef7f28ecb7ae52788e3922d6d Mon Sep 17 00:00:00 2001 From: Sijie Date: Thu, 20 Jun 2024 22:56:24 -0700 Subject: [PATCH 28/43] checkout repo --- .github/workflows/regressiontest_container.yml | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 73d3cf90f..780cf2030 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -31,14 +31,10 @@ jobs: # python3 --version3 # cd $GITHUB_WORKSPACE # ls -la + git clone https://github.com/buildtesters/buildtest.git + cd buildtest + source setup.sh export HOMEDIR=`pwd` - echo $HOMEDIR - - echo "-------------" - ls -la $HOMEDIR - echo "-------------" - - . setup.sh export BUILDTEST_CONFIGFILE=$HOMEDIR/buildtest/settings/spack_container.yml python $HOMEDIR/buildtest/tools/unittests.py -c returncode=$? From 2f6db9309ff21377172f19a87f3603507c503c47 Mon Sep 17 00:00:00 2001 From: Sijie Date: Thu, 20 Jun 2024 23:26:49 -0700 Subject: [PATCH 29/43] check git version --- .github/workflows/regressiontest_container.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 780cf2030..b58003df4 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -8,7 +8,7 @@ jobs: buildtest_tutorial_container: runs-on: ubuntu-latest container: - image: ghcr.io/buildtesters/buildtest_spack + image: ghcr.io/buildtesters/buildtest_spack:spack-sc23 options: "-it --user spack" steps: - name: regression test in container @@ -31,6 +31,7 @@ jobs: # python3 --version3 # cd $GITHUB_WORKSPACE # ls -la + git --version git clone https://github.com/buildtesters/buildtest.git cd buildtest source setup.sh From 6b33bc53185f9f8714cacdd6995302870c78f420 Mon Sep 17 00:00:00 2001 From: Sijie Date: Thu, 20 Jun 2024 23:35:48 -0700 Subject: [PATCH 30/43] check git version --- .github/workflows/regressiontest_container.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index b58003df4..baf886468 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -8,7 +8,7 @@ jobs: buildtest_tutorial_container: runs-on: ubuntu-latest container: - image: ghcr.io/buildtesters/buildtest_spack:spack-sc23 + image: ghcr.io/buildtesters/buildtest_spack options: "-it --user spack" steps: - name: regression test in container @@ -31,6 +31,7 @@ jobs: # python3 --version3 # cd $GITHUB_WORKSPACE # ls -la + cd git --version git clone https://github.com/buildtesters/buildtest.git cd buildtest From 38837f5132889fa3ae30a3fefc050c65297a77cd Mon Sep 17 00:00:00 2001 From: Sijie Date: Thu, 20 Jun 2024 23:42:37 -0700 Subject: [PATCH 31/43] create a workdir --- .github/workflows/regressiontest_container.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index baf886468..f093aa4ea 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -32,7 +32,9 @@ jobs: # cd $GITHUB_WORKSPACE # ls -la cd - git --version + mkdir projects + sudo chmod 777 projects + cd projects git clone https://github.com/buildtesters/buildtest.git cd buildtest source setup.sh From 38fcf9a326b169549da764b4fc2c63f26d637751 Mon Sep 17 00:00:00 2001 From: Sijie Date: Thu, 20 Jun 2024 23:51:48 -0700 Subject: [PATCH 32/43] create a temp workdir --- .github/workflows/regressiontest_container.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index f093aa4ea..1de33cbd4 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -33,7 +33,7 @@ jobs: # ls -la cd mkdir projects - sudo chmod 777 projects + # sudo chmod 777 projects cd projects git clone https://github.com/buildtesters/buildtest.git cd buildtest From 86dcd6e8ef185d60d577184d861b34b2a9079a7a Mon Sep 17 00:00:00 2001 From: Sijie Date: Thu, 20 Jun 2024 23:59:49 -0700 Subject: [PATCH 33/43] log in as root user --- .github/workflows/regressiontest_container.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 1de33cbd4..3c48bfd43 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -9,7 +9,7 @@ jobs: runs-on: ubuntu-latest container: image: ghcr.io/buildtesters/buildtest_spack - options: "-it --user spack" + options: "-it --user root" steps: - name: regression test in container shell: bash @@ -31,9 +31,7 @@ jobs: # python3 --version3 # cd $GITHUB_WORKSPACE # ls -la - cd mkdir projects - # sudo chmod 777 projects cd projects git clone https://github.com/buildtesters/buildtest.git cd buildtest From 18e75084932bdc7073cf520baa02dd4f5469f6ea Mon Sep 17 00:00:00 2001 From: Sijie Date: Fri, 21 Jun 2024 00:10:00 -0700 Subject: [PATCH 34/43] check pip version --- .github/workflows/regressiontest_container.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 3c48bfd43..e6367e09d 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -35,9 +35,10 @@ jobs: cd projects git clone https://github.com/buildtesters/buildtest.git cd buildtest - source setup.sh + pip --version export HOMEDIR=`pwd` export BUILDTEST_CONFIGFILE=$HOMEDIR/buildtest/settings/spack_container.yml + source $HOMEDIR/setup.sh python $HOMEDIR/buildtest/tools/unittests.py -c returncode=$? if [ $returncode != 0 ]; then exit $returncode; fi From 0b02f814e55effec8cd3fd9ef7a0d233427cd830 Mon Sep 17 00:00:00 2001 From: Sijie Date: Fri, 21 Jun 2024 00:23:13 -0700 Subject: [PATCH 35/43] create an env --- .github/workflows/regressiontest_container.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index e6367e09d..7dc24a211 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -35,7 +35,9 @@ jobs: cd projects git clone https://github.com/buildtesters/buildtest.git cd buildtest - pip --version + pip3 --version + python3 -m venv bt + source bt/bin/activate export HOMEDIR=`pwd` export BUILDTEST_CONFIGFILE=$HOMEDIR/buildtest/settings/spack_container.yml source $HOMEDIR/setup.sh From d82ab0df6bc198181d2050770691e8590c3b3638 Mon Sep 17 00:00:00 2001 From: Sijie Date: Fri, 21 Jun 2024 00:35:48 -0700 Subject: [PATCH 36/43] remove comments --- .github/workflows/regressiontest_container.yml | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 7dc24a211..a95f8a362 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -14,28 +14,13 @@ jobs: - name: regression test in container shell: bash run: | - # env - # whoami - # id - # ls -ld $HOME - # echo $HOME - # cd $GITHUB_WORKSPACE - # ls -la $GITHUB_WORKSPACE set +xe . /etc/profile - # module --version - # module avail - # spack --version module load python - which python3 - # python3 --version3 - # cd $GITHUB_WORKSPACE - # ls -la mkdir projects cd projects git clone https://github.com/buildtesters/buildtest.git cd buildtest - pip3 --version python3 -m venv bt source bt/bin/activate export HOMEDIR=`pwd` From 36781d147e00bc837be9958cad12e7d937b13be7 Mon Sep 17 00:00:00 2001 From: Sijie Date: Fri, 21 Jun 2024 00:48:43 -0700 Subject: [PATCH 37/43] Regression test is running --- .github/workflows/regressiontest_container.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index a95f8a362..56e675675 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -21,8 +21,8 @@ jobs: cd projects git clone https://github.com/buildtesters/buildtest.git cd buildtest - python3 -m venv bt - source bt/bin/activate + python3 -m venv env + source env/bin/activate export HOMEDIR=`pwd` export BUILDTEST_CONFIGFILE=$HOMEDIR/buildtest/settings/spack_container.yml source $HOMEDIR/setup.sh From cb46278575939b40755f74bca0d0a2bf2509dc51 Mon Sep 17 00:00:00 2001 From: Sijie Date: Wed, 26 Jun 2024 00:26:32 -0700 Subject: [PATCH 38/43] checkout repo --- .github/workflows/regressiontest_container.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 56e675675..6bf9ad42a 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -11,16 +11,15 @@ jobs: image: ghcr.io/buildtesters/buildtest_spack options: "-it --user root" steps: + - name: Check out the repo + uses: actions/checkout@v4 + - name: regression test in container shell: bash run: | set +xe . /etc/profile module load python - mkdir projects - cd projects - git clone https://github.com/buildtesters/buildtest.git - cd buildtest python3 -m venv env source env/bin/activate export HOMEDIR=`pwd` From 96978c4e26cc6c759fb0ef81a7d416f550cabe1c Mon Sep 17 00:00:00 2001 From: Sijie Date: Wed, 26 Jun 2024 00:41:38 -0700 Subject: [PATCH 39/43] revert to v3 versio --- .github/workflows/regressiontest_container.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 6bf9ad42a..48b4f5d5f 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -12,7 +12,7 @@ jobs: options: "-it --user root" steps: - name: Check out the repo - uses: actions/checkout@v4 + uses: actions/checkout@v3 - name: regression test in container shell: bash From 2d5c919a831f855ec5d6fc489bc3aea4aa704b31 Mon Sep 17 00:00:00 2001 From: Sijie Date: Wed, 26 Jun 2024 22:17:44 -0700 Subject: [PATCH 40/43] tag image --- .github/workflows/regressiontest_container.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index 48b4f5d5f..ba1b8f157 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -8,7 +8,7 @@ jobs: buildtest_tutorial_container: runs-on: ubuntu-latest container: - image: ghcr.io/buildtesters/buildtest_spack + image: ghcr.io/buildtesters/buildtest_spack:spack-sc23 options: "-it --user root" steps: - name: Check out the repo From cf6b4de2264a21b608d1318507ccf7c969e30c6f Mon Sep 17 00:00:00 2001 From: Sijie Date: Wed, 26 Jun 2024 22:40:10 -0700 Subject: [PATCH 41/43] add missing shells --- buildtest/utils/shell.py | 1 + 1 file changed, 1 insertion(+) diff --git a/buildtest/utils/shell.py b/buildtest/utils/shell.py index 768550bfe..59495dece 100755 --- a/buildtest/utils/shell.py +++ b/buildtest/utils/shell.py @@ -141,6 +141,7 @@ def __init__(self, shell="bash"): system_shells + python_shells + ["bash", "csh", "tcsh", "sh", "zsh", "python", "python3"] + + ["/bin/csh"] ) # if input shell is not in list of valid shells we raise error. From 3039f4be3ce717af18bb8b91b36250c894d2916b Mon Sep 17 00:00:00 2001 From: Sijie Date: Wed, 26 Jun 2024 22:49:10 -0700 Subject: [PATCH 42/43] add shell debug --- .github/workflows/regressiontest_container.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/regressiontest_container.yml b/.github/workflows/regressiontest_container.yml index ba1b8f157..2f0ce9072 100644 --- a/.github/workflows/regressiontest_container.yml +++ b/.github/workflows/regressiontest_container.yml @@ -19,6 +19,7 @@ jobs: run: | set +xe . /etc/profile + which csh zsh module load python python3 -m venv env source env/bin/activate From 085b28befbeeedc5a4316d383b14db9814a4c629 Mon Sep 17 00:00:00 2001 From: Sijie Date: Thu, 27 Jun 2024 01:02:39 -0700 Subject: [PATCH 43/43] merge devel into regtest --- buildtest/utils/shell.py | 1 - 1 file changed, 1 deletion(-) diff --git a/buildtest/utils/shell.py b/buildtest/utils/shell.py index 59495dece..768550bfe 100755 --- a/buildtest/utils/shell.py +++ b/buildtest/utils/shell.py @@ -141,7 +141,6 @@ def __init__(self, shell="bash"): system_shells + python_shells + ["bash", "csh", "tcsh", "sh", "zsh", "python", "python3"] - + ["/bin/csh"] ) # if input shell is not in list of valid shells we raise error.