Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CI check for validating tutorial in container #1668

Closed
shahzebsiddiqui opened this issue Nov 20, 2023 · 2 comments
Closed

add CI check for validating tutorial in container #1668

shahzebsiddiqui opened this issue Nov 20, 2023 · 2 comments
Labels
good first issue good first issue for new contributor

Comments

@shahzebsiddiqui
Copy link
Member

We have a buildtest tutorial https://buildtest.readthedocs.io/en/devel/buildspec_tutorial.html that is conducted in container imageghcr.io/buildtesters/buildtest_spack:latest that is not being tested. For instance, the spack regresion test check https://github.com/buildtesters/buildtest/blob/devel/tests/buildsystem/test_spack.py file is written to be tested in the container image.

We would like to add a Github workflow CI check that can test inside the container. GitHub supports running test in container.
@shahzebsiddiqui shahzebsiddiqui added the good first issue good first issue for new contributor label Nov 20, 2023
@shahzebsiddiqui
Copy link
Member Author

There is an initial prototype of this work which is not complete see #1635

@shahzebsiddiqui
Copy link
Member Author

This is addressed in #1716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue good first issue for new contributor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shahzebsiddiqui