Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Observability via OpenTelemetry Traces #299

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

joshwlewis
Copy link
Member

@joshwlewis joshwlewis commented Oct 6, 2023

This RFC introduces a solution to build observability via OpenTelemetry Traces and the OpenTelemetry File Export format.

Readable

@buildpack-bot
Copy link
Member

Maintainers,

As you review this RFC please queue up issues to be created using the following commands:

/queue-issue <repo> "<title>" [labels]...
/unqueue-issue <uid>

Issues

(none)

@joshwlewis joshwlewis force-pushed the build-observability branch 2 times, most recently from b327ca9 to e34a900 Compare April 24, 2024 15:41
@joshwlewis joshwlewis marked this pull request as ready for review April 24, 2024 15:41
@joshwlewis joshwlewis changed the title Draft: Build Observability Draft: Build Observability via OpenTelemetry Traces Apr 24, 2024
@joshwlewis joshwlewis changed the title Draft: Build Observability via OpenTelemetry Traces Build Observability via OpenTelemetry Traces Apr 24, 2024
@jkutner
Copy link
Member

jkutner commented Jun 13, 2024

@joshwlewis can you DCO those last commits (and maybe squash em)

Copy link
Member

@natalieparellano natalieparellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I very much support this proposal. I have my quibbles about where the files should be output, but I think whatever we eventually settle on will be fine.

Signed-off-by: Josh W Lewis <[email protected]>

Update telemetry file location

Signed-off-by: Josh W Lewis <[email protected]>

Ad drawback about /layers/tracing

Signed-off-by: Josh W Lewis <[email protected]>
@joshwlewis joshwlewis force-pushed the build-observability branch from 6f37716 to 4f5e23b Compare August 15, 2024 17:07
@jabrown85
Copy link
Contributor

Ready to merge @hone !

jabrown85 added a commit that referenced this pull request Aug 22, 2024
[#299]

Signed-off-by: Jesse Brown <[email protected]>
@jabrown85 jabrown85 merged commit 5e8e3b2 into buildpacks:main Aug 22, 2024
7 checks passed
@joshwlewis joshwlewis deleted the build-observability branch September 5, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants