Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The creator should fail after detect if the found group contains extensions #1241

Closed
natalieparellano opened this issue Nov 13, 2023 · 0 comments · Fixed by #1246
Closed

The creator should fail after detect if the found group contains extensions #1241

natalieparellano opened this issue Nov 13, 2023 · 0 comments · Fixed by #1246
Labels
status/ready type/enhancement New feature or request
Milestone
lifecycle 0.19.0

Comments

@natalieparellano
Copy link
Member

Summary

See buildpacks/community#244 - this would allow platforms like pack to run the creator and only fail out if the build truly can't continue.

Proposal

We can just check the group after detector.Detect() has run.

Related

RFC #___

Context

Related to #1155 but that would take a bit more work to implement. However, this issue is a step in that direction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/ready type/enhancement New feature or request
Projects
None yet
Milestone
lifecycle 0.19.0
Development

Successfully merging a pull request may close this issue.

Creator errors if detected order contains extensions buildpacks/lifecycle
1 participant
@natalieparellano