Use actions/setup-go for unit-test workflow #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i think we were relying on the go toolchain available inside the runner image, which could be out of date. Instead we should use the setup-go action which should have the latest version of the toolchain Signed-off-by: Bohan Chen <[email protected]>
otherwise it'll use the system toolchain to run report.go, which will fail when it encounters the new `toolchain` directive in the root go.mod Signed-off-by: Bohan Chen <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1381 +/- ##
=======================================
Coverage 67.17% 67.17%
=======================================
Files 134 134
Lines 8276 8276
=======================================
Hits 5559 5559
Misses 2264 2264
Partials 453 453 ☔ View full report in Codecov by Sentry. |
tomkennedy513
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were relying on the go toolchain available inside the runner image which is 1.20 or something. Instead we should use the setup-go action which should have the latest version of the toolchain (1.21).