Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support images in Avatar #275

Open
gabro opened this issue Jul 15, 2022 · 0 comments
Open

Support images in Avatar #275

gabro opened this issue Jul 15, 2022 · 0 comments

Comments

@gabro
Copy link
Member

gabro commented Jul 15, 2022

Avatar should accept an optional imageSrc prop.

It would be cool if we could show the default icon (or initial, depending on whether username is set or not) while the image is loading or if the image fails loading (possibly because the url is wrong or unreachable)

I think it may be achievable by using an <object> tag and nesting the fallback in it, but I haven't explored it much
@gabro gabro added this to Bento Jul 15, 2022
@gabro gabro moved this to Todo in Bento Jul 15, 2022
@Reggionick Reggionick self-assigned this Jul 19, 2022
@Reggionick Reggionick linked a pull request Jul 19, 2022 that will close this issue
Added Avatar image prop #287
Closed
@Phyele Phyele moved this from To do to In progress in Bento Jul 22, 2022
@gabro gabro moved this from In progress to To do in Bento Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Bento
Status: To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Avatar image prop buildo/bento-design-system
2 participants
@gabro @Reggionick