From 71689dff140fdafa2c2002ca15e7778ea1ed3c6d Mon Sep 17 00:00:00 2001
From: Gabriele Petronella <gabriele@buildo.io>
Date: Wed, 18 Jan 2023 11:29:17 +0100
Subject: [PATCH] Allow interactive rows on Table

---
 .../bento-design-system/src/Table/Config.ts   |  5 ++
 .../src/Table/Table.css.ts                    | 36 ++++++++++---
 .../bento-design-system/src/Table/Table.tsx   | 50 +++++++++++++++++--
 .../src/util/defaultConfigs.tsx               |  1 +
 .../stories/Components/Table.stories.tsx      |  7 +++
 5 files changed, 88 insertions(+), 11 deletions(-)

diff --git a/packages/bento-design-system/src/Table/Config.ts b/packages/bento-design-system/src/Table/Config.ts
index 0a6e0f4b5..d4d83175d 100644
--- a/packages/bento-design-system/src/Table/Config.ts
+++ b/packages/bento-design-system/src/Table/Config.ts
@@ -2,6 +2,7 @@ import { TooltipPlacement } from "../Field/FieldProps";
 import { IconProps } from "../Icons";
 import { IllustrationProps } from "../Illustrations";
 import { BentoSprinkles } from "../internal";
+import { vars } from "../vars.css";
 
 type CellPaddingConfig = {
   paddingX: BentoSprinkles["paddingX"];
@@ -16,6 +17,10 @@ export type TableConfig = {
   hintPlacement: TooltipPlacement;
   cellTooltipPlacement: TooltipPlacement;
   evenRowsBackgroundColor: BentoSprinkles["background"];
+  // NOTE(gabro): not using BentoSprinkles["background"] because we only want
+  // "plain" values to use directly in CSS and not conditional objects like
+  // { default: ..., hover: ... }
+  selectedRowBackgroundColor: keyof typeof vars.backgroundColor;
   padding: {
     header: CellPaddingConfig;
     defaultCell: CellPaddingConfig;
diff --git a/packages/bento-design-system/src/Table/Table.css.ts b/packages/bento-design-system/src/Table/Table.css.ts
index 67885f47d..73eb34bed 100644
--- a/packages/bento-design-system/src/Table/Table.css.ts
+++ b/packages/bento-design-system/src/Table/Table.css.ts
@@ -1,5 +1,6 @@
-import { style } from "@vanilla-extract/css";
+import { createVar, style } from "@vanilla-extract/css";
 import { bentoSprinkles } from "../internal";
+import { strictRecipe } from "../util/strictRecipe";
 
 export const table = style({
   gridAutoRows: "max-content",
@@ -29,11 +30,34 @@ export const stickyColumnHeader = bentoSprinkles({
   top: 0,
 });
 
-export const cellContainer = bentoSprinkles({
-  height: "full",
-  display: "flex",
-  flexDirection: "column",
-  justifyContent: "center",
+export const rowContainer = style({
+  // NOTE(gabro): this allows us to use the entire row as a parent selector,
+  // for applying a hover effect on all of its children or clicking on row,
+  // without intrucing a DOM container that would break the grid layout.
+  display: "contents",
+});
+
+export const selectedRowBackgroundColor = createVar();
+
+export const cellContainerRecipe = strictRecipe({
+  base: bentoSprinkles({
+    height: "full",
+    display: "flex",
+    flexDirection: "column",
+    justifyContent: "center",
+  }),
+  variants: {
+    interactiveRow: {
+      true: {
+        selectors: {
+          [`${rowContainer}:hover &`]: {
+            cursor: "pointer",
+            background: selectedRowBackgroundColor,
+          },
+        },
+      },
+    },
+  },
 });
 
 export const sectionHeaderContainer = style([
diff --git a/packages/bento-design-system/src/Table/Table.tsx b/packages/bento-design-system/src/Table/Table.tsx
index 1b6471f2c..371b41917 100644
--- a/packages/bento-design-system/src/Table/Table.tsx
+++ b/packages/bento-design-system/src/Table/Table.tsx
@@ -26,13 +26,16 @@ import {
   IconButton,
   Tooltip,
   FeedbackProps,
+  vars,
 } from "..";
 import {
-  cellContainer,
+  cellContainerRecipe,
   columnHeader,
   lastLeftStickyColumn,
+  rowContainer,
   sectionHeader,
   sectionHeaderContainer,
+  selectedRowBackgroundColor,
   sortIconContainer,
   stickyColumnHeader,
   table,
@@ -42,6 +45,7 @@ import { useLayoutEffect, useMemo, useState, CSSProperties, useEffect } from "re
 import { IconHelp, IconInfo } from "../Icons";
 import { match, __ } from "ts-pattern";
 import { useBentoConfig } from "../BentoConfigContext";
+import { assignInlineVars } from "@vanilla-extract/dynamic";
 
 type SortFn<C extends ReadonlyArray<ColumnType<string, {}, any>>> = (
   a: Row<RowType<C>>,
@@ -80,6 +84,7 @@ type Props<C extends ReadonlyArray<ColumnType<string, {}, any>>> = {
   initialSorting?: Array<SortingRule<C>>;
   stickyHeaders?: boolean;
   height?: { custom: string | number };
+  onRowPress?: (row: Row<RowType<C>>) => void;
 } & SortingProps<C>;
 
 /**
@@ -113,6 +118,7 @@ export function Table<C extends ReadonlyArray<ColumnType<string, {}, any>>>({
   initialSorting,
   stickyHeaders,
   height,
+  onRowPress,
 }: Props<C>) {
   const config = useBentoConfig().table;
   const customOrderByFn = useMemo(
@@ -273,7 +279,11 @@ export function Table<C extends ReadonlyArray<ColumnType<string, {}, any>>>({
     .map(({ gridWidth = "fit-content" }) => gridWidthStyle(gridWidth))
     .join(" ");
 
-  function renderCells<D extends Record<string, unknown>>(cells: Array<Cell<D>>, rowIndex: number) {
+  function renderCells<D extends Record<string, unknown>>(
+    cells: Array<Cell<D>>,
+    rowIndex: number,
+    interactiveRow: boolean
+  ) {
     return cells.map((cell, index) => (
       <CellContainer
         {...cell.getCellProps()}
@@ -282,6 +292,7 @@ export function Table<C extends ReadonlyArray<ColumnType<string, {}, any>>>({
         style={stickyLeftColumnStyle[cell.column.id]}
         first={index === 0}
         last={(index + 1) % columns.length === 0}
+        interactiveRow={interactiveRow}
       >
         {cell.render("Cell")}
       </CellContainer>
@@ -321,18 +332,45 @@ export function Table<C extends ReadonlyArray<ColumnType<string, {}, any>>>({
             />,
             ...row.leafRows.map((row, index) => {
               prepareRow(row);
-              return renderCells(row.cells, index);
+              return renderCells(row.cells, index, false);
             }),
           ];
         } else {
           prepareRow(row);
-          return [renderCells(row.cells, index)];
+          return (
+            <RowContainer key={index} row={row} onPress={onRowPress}>
+              {renderCells(row.cells, index, onRowPress !== undefined)}
+            </RowContainer>
+          );
         }
       })}
     </Box>
   );
 }
 
+function RowContainer<C extends ReadonlyArray<ColumnType<string, {}, any>>>({
+  row,
+  children,
+  onPress,
+}: {
+  row: Row<RowType<C>>;
+  onPress: ((row: Row<RowType<C>>) => void) | undefined;
+  children: Children;
+}) {
+  const config = useBentoConfig().table;
+  return (
+    <Box
+      className={rowContainer}
+      style={assignInlineVars({
+        [selectedRowBackgroundColor]: vars.backgroundColor[config.selectedRowBackgroundColor],
+      })}
+      onClick={() => onPress?.(row)}
+    >
+      {children}
+    </Box>
+  );
+}
+
 function ColumnHeader<D extends Record<string, unknown>>({
   column,
   style,
@@ -484,6 +522,7 @@ function CellContainer({
   lastLeftSticky,
   first,
   last,
+  interactiveRow,
   ...props
 }: {
   children: any;
@@ -492,6 +531,7 @@ function CellContainer({
   lastLeftSticky: boolean;
   first: boolean;
   last: boolean;
+  interactiveRow: boolean;
 } & TableCellProps) {
   const tableConfig = useBentoConfig().table;
 
@@ -499,7 +539,7 @@ function CellContainer({
     <Box className={lastLeftSticky && lastLeftStickyColumn} style={style}>
       <Box
         background={index % 2 === 0 ? tableConfig.evenRowsBackgroundColor : "backgroundPrimary"}
-        className={cellContainer}
+        className={cellContainerRecipe({ interactiveRow })}
         paddingLeft={first ? tableConfig.boundaryPadding : undefined}
         paddingRight={last ? tableConfig.boundaryPadding : undefined}
         {...props}
diff --git a/packages/bento-design-system/src/util/defaultConfigs.tsx b/packages/bento-design-system/src/util/defaultConfigs.tsx
index 87200697c..c4a12b8af 100644
--- a/packages/bento-design-system/src/util/defaultConfigs.tsx
+++ b/packages/bento-design-system/src/util/defaultConfigs.tsx
@@ -467,6 +467,7 @@ export const table: TableConfig = {
   hintPlacement: "top",
   cellTooltipPlacement: "bottom",
   evenRowsBackgroundColor: "backgroundSecondary",
+  selectedRowBackgroundColor: "backgroundInteractiveOverlay",
   padding: {
     header: { paddingX: 16, paddingY: 8 },
     defaultCell: { paddingX: 16, paddingY: 16 },
diff --git a/packages/storybook/stories/Components/Table.stories.tsx b/packages/storybook/stories/Components/Table.stories.tsx
index c38b630eb..f017a2429 100644
--- a/packages/storybook/stories/Components/Table.stories.tsx
+++ b/packages/storybook/stories/Components/Table.stories.tsx
@@ -438,3 +438,10 @@ export const CustomizedColumns = createStory({
   columns: customizedColumns,
   data: exampleData,
 });
+
+export const InteractiveRow = createStory({
+  columns: exampleColumns,
+  data: exampleData,
+  initialSorting: [{ id: "name" }],
+  onRowPress: action("onRowPress"),
+});