Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences from NuGet package and this source? #7

Open
coenvdwel opened this issue Mar 23, 2018 · 4 comments
Open

Differences from NuGet package and this source? #7

coenvdwel opened this issue Mar 23, 2018 · 4 comments

Comments

@coenvdwel
Copy link
Contributor

How come the NuGet package depends on Newtonsoft 10.x.x while this repo shows a dependency on 9.x.x? It is also not targeting .NET Standard 2.0, which the NuGet package does.

This prevents me from loading my own fork in my project, where I am adding support for some payment methods such as Bancontact and AfterPay.

@FrostAndFlame
Copy link

@coenvdwel Yeah, this is true - NuGet package is outdated.
https://www.nuget.org/packages/BuckarooSDK/
last updated 8 months ago 👎
Your latest fixes aren't included in NuGet package
(https://github.com/buckaroo-it/BuckarooSdk_DotNet/pull/6/files)
@buckaroo-it @sjaak-buckaroo

@coenvdwel
Copy link
Contributor Author

(for the record; we've moved to using our own fork to avoid these issues, among others)

@FrostAndFlame
Copy link

FrostAndFlame commented Oct 2, 2018

(for the record; we've moved to using our own fork to avoid these issues, among others)

@coenvdwel
Do you have public Nuget package for it ?

@coenvdwel
Copy link
Contributor Author

(for the record; we've moved to using our own fork to avoid these issues, among others)

@coenvdwel
Do you have public Nuget package for it ?

Never bothered, but I've now pushed it! 🎂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants