Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpClient scope #35

Open
theo-albers opened this issue Jul 13, 2019 · 6 comments
Open

HttpClient scope #35

theo-albers opened this issue Jul 13, 2019 · 6 comments

Comments

@theo-albers
Copy link

The Connection class creates an HttpClient and DelegatingHandler on every request. This is bad practice in a server environment like ASP.NET, see
https://docs.microsoft.com/en-us/dotnet/standard/microservices-architecture/implement-resilient-applications/use-httpclientfactory-to-implement-resilient-http-requests. It would be very nice to be able to control the HttpClient or DelegateHandler lifetime as SDK consumer. Right now we can't use the SDK (or we would have to clone and modify the source).

@buckaroo-it
Copy link
Collaborator

buckaroo-it commented Jul 23, 2019

Thank you for your suggestion. we will take a look at this as I agree with your point of view on this matter. I will at least provide you with the intended solution and the timeline to implement the fix. In the coming weeks we are short staffed and a change like this needs to be tested thoroughly. I will come back to you. greetings

@jonassix
Copy link

jonassix commented Apr 1, 2020

Hi,

What is the status of this?

@stefankip
Copy link

...

@jonassix
Copy link

...

Yeah, they won't respond. I've developed my own implementation faster than they are even able to respond

@timvandenhof
Copy link

Yeah, they won't respond. I've developed my own implementation faster than they are even able to respond

Can you open a PR for them so other can profit too?
My current team is implementing Buckaroo at the moment, and this could hinder our performance as mentioned by Theo.

@jonassix
Copy link

I've written an entire code base from scratch. It's not a fork and it's not open source.
So won't do a PR.

This library was very handy as a form of documenation. For how authentication works , how the message's are constructed.
Imo the only "difficult" thing was the authentication. So my advice would be to just build your own implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants