-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HttpClient scope #35
Comments
Thank you for your suggestion. we will take a look at this as I agree with your point of view on this matter. I will at least provide you with the intended solution and the timeline to implement the fix. In the coming weeks we are short staffed and a change like this needs to be tested thoroughly. I will come back to you. greetings |
Hi, What is the status of this? |
... |
Yeah, they won't respond. I've developed my own implementation faster than they are even able to respond |
Can you open a PR for them so other can profit too? |
I've written an entire code base from scratch. It's not a fork and it's not open source. This library was very handy as a form of documenation. For how authentication works , how the message's are constructed. |
The Connection class creates an HttpClient and DelegatingHandler on every request. This is bad practice in a server environment like ASP.NET, see
https://docs.microsoft.com/en-us/dotnet/standard/microservices-architecture/implement-resilient-applications/use-httpclientfactory-to-implement-resilient-http-requests. It would be very nice to be able to control the HttpClient or DelegateHandler lifetime as SDK consumer. Right now we can't use the SDK (or we would have to clone and modify the source).
The text was updated successfully, but these errors were encountered: