Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebars w/ empty BU Text/Link Widgets Produce Wrong Class Counts #45

Open
sr4136 opened this issue Sep 4, 2018 · 1 comment · May be fixed by #96
Open

Sidebars w/ empty BU Text/Link Widgets Produce Wrong Class Counts #45

sr4136 opened this issue Sep 4, 2018 · 1 comment · May be fixed by #96
Labels
🔥 Product bug A bug which is not directly related to a custom child theme.

Comments

@sr4136
Copy link
Collaborator

sr4136 commented Sep 4, 2018 •
edited by alana29s
Loading

See note on line 129-130
https://github.com/bu-ist/responsive-framework/blob/develop/inc/extras.php#L122-L185

How do we ensure, in a not-costly manner, that correct widget counts get output?

I foresee needing a helper function, to apply to multiple scenarios. An additional one is that the surrounding sidebar markup (<aside>, <h2>, etc) shouldn't get output when the only widgets in a sidebar are empty BU Text/Link widgets.
https://github.com/bu-ist/responsive-framework/blob/5651b9f53293c3743186bb23e8c8be6120740123/sidebar.php
@hirozed hirozed assigned hirozed and unassigned hirozed Sep 4, 2018
@alana29s alana29s mentioned this issue Sep 20, 2018
Closed
@alana29s
Copy link
Contributor

Example: In the image below the widget- class increments when no widget is output. In this example, there were two BU Text widgets, the second widget was empty, but the widget count is still incremented.

screen shot 2018-09-20 at 3 06 39 pm

@alana29s alana29s linked a pull request Sep 21, 2018 that will close this issue
Open
@acketon acketon added the 🔥 Product bug A bug which is not directly related to a custom child theme. label Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔥 Product bug A bug which is not directly related to a custom child theme.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bypass empty BU Text widgets in class count increment via filter bu-ist/responsive-framework
4 participants
@hirozed @acketon @sr4136 @alana29s