From 027a886de9169629296997119db5611d59eec9f1 Mon Sep 17 00:00:00 2001 From: ashleykolodziej Date: Fri, 10 Aug 2018 13:48:45 -0400 Subject: [PATCH 1/6] Version bump --- CHANGELOG.md | 3 +++ bower.json | 2 +- package.json | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ba886eed..adb4a27a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,8 @@ # Changelog +## 2.1.11 +* Fixes an issue with external linking. This is a required update for all 2.0 themes. + ## 2.1.1 * Adds skip-link feature for keyboard navigation. This is a required update for all 2.0 themes. diff --git a/bower.json b/bower.json index 54b79394..1717bfb1 100644 --- a/bower.json +++ b/bower.json @@ -1,6 +1,6 @@ { "name": "responsive-foundation", - "version": "2.1.1", + "version": "2.1.11", "homepage": "https://github.com/bu-ist/responsive-foundation", "authors": [ "Mike Burns ", diff --git a/package.json b/package.json index 2d74ecdf..f6806c26 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "responsive-foundation", - "version": "2.1.1", + "version": "2.1.11", "devDependencies": { "grunt": "~0.4.5", "grunt-bower-task": "^0.4.0", From b04c9ae3df11784be0ebf291302b475d81a7c988 Mon Sep 17 00:00:00 2001 From: acacase Date: Tue, 18 Sep 2018 11:39:59 -0400 Subject: [PATCH 2/6] updated styles for skip link - updated positioning - updated size --- css-dev/burf-theme/layout/_navigation.scss | 34 ++++++++++++---------- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/css-dev/burf-theme/layout/_navigation.scss b/css-dev/burf-theme/layout/_navigation.scss index 97d972c1..a07b180b 100644 --- a/css-dev/burf-theme/layout/_navigation.scss +++ b/css-dev/burf-theme/layout/_navigation.scss @@ -1007,9 +1007,9 @@ $no-nav-desktop: $nav-desktop !default; // Adjusts the appearance of the skip link; Styled to match the default WordPress screen reader text .skip-link { - - background-color: #f1f1f1; -webkit-box-shadow: 0 0 2px 2px rgba( 0, 0, 0, 0.6 ); + -webkit-transition: top 0.75s ease-out; + background-color: #f1f1f1; box-shadow: 0 0 2px 2px rgba( 0, 0, 0, 0.6 ); color: #21759b; display: block; @@ -1017,25 +1017,29 @@ $no-nav-desktop: $nav-desktop !default; font-size: 14px; font-weight: 700; height: auto; - left: 6px; + left: 50%; line-height: normal; - margin: 30px 45%; + margin: 0; padding: 15px 23px 14px; position: absolute; + right: 50%; + text-align: center; text-decoration: none; - top: -100px; - -webkit-transition: top 0.75s ease-out; + top: -130px; + transform: translateX( -50% ); transition: top 0.75s ease-out; - width: auto; + width: 90%; z-index: 100000; - -} -.skip-link:focus, -.skip-link:active { - color: #21759b; - top: 7px; + @include breakpoint( $xs ) { + width: 190px; + } - -webkit-transition: top 0s; - transition: top 0s; + &:focus, + &:active { + -webkit-transition: top 0s; + color: #21759b; + top: 37px; + transition: top 0s; + } } From b3a85bda35b3e3b1aa799121073baeab96161a5c Mon Sep 17 00:00:00 2001 From: acacase Date: Tue, 18 Sep 2018 11:43:22 -0400 Subject: [PATCH 3/6] updated changelog --- CHANGELOG.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index adb4a27a..f675cdc0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,8 @@ # Changelog +## Unreleased +* Fixed size and positioning of skip-link. + ## 2.1.11 * Fixes an issue with external linking. This is a required update for all 2.0 themes. @@ -8,9 +11,6 @@ ## 2.1.0 * Color contrast accessibility fixes to comply with MWAS - -## Unreleased - * Fixed a bug with the left hand nav layout and BU Banners [See related pull request](https://github.com/bu-ist/responsive-foundation/pull/154) * Fixed a bug with the search box in IE [See related pull request](https://github.com/bu-ist/responsive-foundation/pull/156) * Fixed a bug with the profile single photos [See related pull request](https://github.com/bu-ist/responsive-foundation/pull/159) From 4e1c2c7ab457be86dd91ede20d275bb8acdc4ad1 Mon Sep 17 00:00:00 2001 From: acacase Date: Tue, 18 Sep 2018 16:01:04 -0400 Subject: [PATCH 4/6] cc fixes --- CHANGELOG.md | 1 + css-dev/burf-theme/layout/_navigation.scss | 7 +++---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f675cdc0..970be3a0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ # Changelog ## Unreleased + * Fixed size and positioning of skip-link. ## 2.1.11 diff --git a/css-dev/burf-theme/layout/_navigation.scss b/css-dev/burf-theme/layout/_navigation.scss index a07b180b..cd26146f 100644 --- a/css-dev/burf-theme/layout/_navigation.scss +++ b/css-dev/burf-theme/layout/_navigation.scss @@ -1007,10 +1007,8 @@ $no-nav-desktop: $nav-desktop !default; // Adjusts the appearance of the skip link; Styled to match the default WordPress screen reader text .skip-link { - -webkit-box-shadow: 0 0 2px 2px rgba( 0, 0, 0, 0.6 ); - -webkit-transition: top 0.75s ease-out; + @include box-shadow(0 0 2px 2px transparentize( $color-grayscale-0, 0.4 )); background-color: #f1f1f1; - box-shadow: 0 0 2px 2px rgba( 0, 0, 0, 0.6 ); color: #21759b; display: block; font-family: "Open Sans",sans-serif; @@ -1027,6 +1025,7 @@ $no-nav-desktop: $nav-desktop !default; text-decoration: none; top: -130px; transform: translateX( -50% ); + -webkit-transition: top 0.75s ease-out; transition: top 0.75s ease-out; width: 90%; z-index: 100000; @@ -1037,9 +1036,9 @@ $no-nav-desktop: $nav-desktop !default; &:focus, &:active { - -webkit-transition: top 0s; color: #21759b; top: 37px; + -webkit-transition: top 0s; transition: top 0s; } } From 3b2192a1596f88bee1f2b7c7173677cda48d8b6a Mon Sep 17 00:00:00 2001 From: acacase Date: Tue, 18 Sep 2018 16:02:36 -0400 Subject: [PATCH 5/6] more cc fixes --- css-dev/burf-theme/layout/_navigation.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/css-dev/burf-theme/layout/_navigation.scss b/css-dev/burf-theme/layout/_navigation.scss index cd26146f..e656eb79 100644 --- a/css-dev/burf-theme/layout/_navigation.scss +++ b/css-dev/burf-theme/layout/_navigation.scss @@ -1007,7 +1007,7 @@ $no-nav-desktop: $nav-desktop !default; // Adjusts the appearance of the skip link; Styled to match the default WordPress screen reader text .skip-link { - @include box-shadow(0 0 2px 2px transparentize( $color-grayscale-0, 0.4 )); + @include box-shadow( 0 0 2px 2px transparentize( $color-grayscale-0, 0.4 ) ); background-color: #f1f1f1; color: #21759b; display: block; From 38105b88590a619beab11e1759b37335f852380d Mon Sep 17 00:00:00 2001 From: Todd Milliken Date: Fri, 9 Nov 2018 14:42:32 -0500 Subject: [PATCH 6/6] Version bump to 2.1.12 This release includes the skip-link style updates from previous commits on `develop`. --- bower.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bower.json b/bower.json index 1717bfb1..951360a9 100644 --- a/bower.json +++ b/bower.json @@ -1,6 +1,6 @@ { "name": "responsive-foundation", - "version": "2.1.11", + "version": "2.1.12", "homepage": "https://github.com/bu-ist/responsive-foundation", "authors": [ "Mike Burns ", diff --git a/package.json b/package.json index f6806c26..59ab8408 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "responsive-foundation", - "version": "2.1.11", + "version": "2.1.12", "devDependencies": { "grunt": "~0.4.5", "grunt-bower-task": "^0.4.0",