Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI is broken on Windows for v3.0.0 #119

Open
Turbo87 opened this issue Dec 5, 2019 · 3 comments
Open

CI is broken on Windows for v3.0.0 #119

Turbo87 opened this issue Dec 5, 2019 · 3 comments

Comments

@Turbo87
Copy link

Turbo87 commented Dec 5, 2019

/cc @stefanpenner
@stefanpenner
Copy link
Contributor

stefanpenner commented Dec 5, 2019 •
edited
Loading

Windows test is failing at broken link test because of nodejs/node#30538

context: #117 (comment)
commit to fix in node: pd4d10/node@842dcf3

TL;DR: bug in node, hopefully they release new patch versions with the fix soon. If not, we can consider skipping those tests. @Turbo87 thoughts?

@Turbo87
Copy link
Author

Turbo87 commented Dec 5, 2019

is that a problem in our tests or in the library code? I'm wondering if we need a workaround for the node versions that have this bug?

@stefanpenner
Copy link
Contributor

TL;DR existsSync is sorta broken. We could provide a wrapper that likely works around it, but we can't really guarentee all other usages of it in an app are using said wrapper. I kinda think (unless this appears in bug reports) that @SparshithNR approach of getting node core to fix is the right path.

But i can be convinced.

@stefanpenner stefanpenner mentioned this issue Dec 10, 2019
Merged
@SparshithNR SparshithNR mentioned this issue Feb 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanpenner @Turbo87