Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of taxonomic classifier trainer wdl #459

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

golu099
Copy link
Contributor

@golu099 golu099 commented Mar 24, 2023

Description of WDL: User imports OTU sequences and taxonomy from desired rRNA database for classifier training on target region.

Copy link
Member

@dpark01 dpark01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, just some small things

pipes/WDL/tasks/tasks_16S_amplicon.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_16S_amplicon.wdl Outdated Show resolved Hide resolved
pipes/WDL/workflows/train_16S_classifier.wdl Outdated Show resolved Hide resolved
pipes/WDL/workflows/train_16S_classifier.wdl Outdated Show resolved Hide resolved
pipes/WDL/workflows/16S_train_classifier.wdl Show resolved Hide resolved
@golu099
Copy link
Contributor Author

golu099 commented May 2, 2023

I think this PR is good to go, from what i see now more comment/edits were made for this PR.

@dpark01
Copy link
Member

dpark01 commented May 2, 2023

This is great, I think the only things left are:

  1. git rm pipes/WDL/workflows/16S_train_classifier.wdl from this branch (see image below, you've still got a vestigal file in this PR)
  2. update the branch to the latest master

image

@dpark01
Copy link
Member

dpark01 commented Mar 19, 2024

This PR looks a bit stale -- let's figure out where we left it off and sort it out one way or the other?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants