-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support private repositories #41
Comments
@ScopeyNZ Yes we are getting a lot of errors coming through on raygun for this. It'd be good to even have an option to skip certain repo's via yml config - if that's not against the philosophy of this module. |
Hi @Leapfrognz . Are you running the latest version of this module? It should just log failures with Composer now - not throw errors. |
Im still on SS v3.7.3 - CWP v1.9.1, so v1.0.1 of this module |
Any ideas on this? Our Raygun account is getting hammered. |
Right so you're getting the I'm not completely familiar with the default log level that's captured by the Raygun module. |
@Leapfrognz you could use your own version of CheckComposerUpdatesExtension with Injector, override I think we could also look at adding a module blacklist of some sort too, which you could add private repositories into. |
@robbieaverill I feel this would be better in the module itself, given we'd have a lot of CWP stacks that need it. And if we override the error reporting level we run the risk of ignoring errors we need to know about. |
@Leapfrognz yes of course! I'm suggesting this as a temporary workaround for your projects using Raygun and private repositories. We'll get this into the backlog to fix at some stage. |
Hey @Leapfrognz . I just noticed that there was a fix sitting in the https://github.com/bringyourownideas/silverstripe-composer-update-checker/releases/tag/1.0.2 Can you try updating to that version and seeing if that has resolved your issue? It should be unrelated but we were getting reports of logs being polluted due to missing this change. |
Yes this seems to fix permissions issues on the composer home dir. Im working on a PR for ignored packages. Should be ready in a moment. |
The latest CWP required version 2.0.3 still doesn't correctly support |
Follow up from #37
Currently this module does not support private repositories. There are a few ways that repositories can be provided in a composer.json: https://getcomposer.org/doc/05-repositories.md . We will need to have a way to ensure authenticated access using these methods.
The text was updated successfully, but these errors were encountered: