Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support private repositories #41

Open
ScopeyNZ opened this issue Aug 23, 2018 · 11 comments
Open

Support private repositories #41

ScopeyNZ opened this issue Aug 23, 2018 · 11 comments

Comments

@ScopeyNZ
Copy link
Contributor

Follow up from #37

Currently this module does not support private repositories. There are a few ways that repositories can be provided in a composer.json: https://getcomposer.org/doc/05-repositories.md . We will need to have a way to ensure authenticated access using these methods.

@Leapfrognz
Copy link

@ScopeyNZ Yes we are getting a lot of errors coming through on raygun for this. It'd be good to even have an option to skip certain repo's via yml config - if that's not against the philosophy of this module.

@ScopeyNZ
Copy link
Contributor Author

Hi @Leapfrognz . Are you running the latest version of this module? It should just log failures with Composer now - not throw errors.

https://github.com/creative-commoners/silverstripe-composer-update-checker/blob/2.0/src/Extensions/CheckComposerUpdatesExtension.php#L57-L66

@Leapfrognz
Copy link

Im still on SS v3.7.3 - CWP v1.9.1, so v1.0.1 of this module
The SS Ragun module we are using still seems to catch SS_Log::log() anyway.

@Leapfrognz
Copy link

Any ideas on this? Our Raygun account is getting hammered.

@ScopeyNZ
Copy link
Contributor Author

ScopeyNZ commented Mar 4, 2019

Right so you're getting the SS_Log entries coming into Raygun then? If the problem will be resolved by dropping the severity of the log entry (down from SS_Log::WARN) then I'm keen to review a PR that does that.

I'm not completely familiar with the default log level that's captured by the Raygun module.

@robbieaverill
Copy link
Contributor

@Leapfrognz you could use your own version of CheckComposerUpdatesExtension with Injector, override updatePackageInfo() and adjust the SS_Log calls, or add some pattern matching to ignore specific errors like the one you're experiencing.

I think we could also look at adding a module blacklist of some sort too, which you could add private repositories into.

@Leapfrognz
Copy link

@robbieaverill I feel this would be better in the module itself, given we'd have a lot of CWP stacks that need it. And if we override the error reporting level we run the risk of ignoring errors we need to know about.

@robbieaverill
Copy link
Contributor

@Leapfrognz yes of course! I'm suggesting this as a temporary workaround for your projects using Raygun and private repositories. We'll get this into the backlog to fix at some stage.

@ScopeyNZ
Copy link
Contributor Author

ScopeyNZ commented Mar 4, 2019

Hey @Leapfrognz . I just noticed that there was a fix sitting in the 1 branch that was unreleased. I've released that fix now:

https://github.com/bringyourownideas/silverstripe-composer-update-checker/releases/tag/1.0.2

Can you try updating to that version and seeing if that has resolved your issue?

It should be unrelated but we were getting reports of logs being polluted due to missing this change.

@Leapfrognz
Copy link

Yes this seems to fix permissions issues on the composer home dir. Im working on a PR for ignored packages. Should be ready in a moment.

@michalkleiner
Copy link

michalkleiner commented Jul 7, 2020

The latest CWP required version 2.0.3 still doesn't correctly support git+ssh specified (public but possibly also private) repositories, though it might be a CWP issue where, for whatever reason, the repo can't be cloned locally in order to check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants