Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEGV when querying Parquet for mgbench bench1/q3 #5500

Open
philrz opened this issue Nov 23, 2024 · 0 comments
Open

SEGV when querying Parquet for mgbench bench1/q3 #5500

philrz opened this issue Nov 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@philrz
Copy link
Contributor

philrz commented Nov 23, 2024

Repro is with:

  • super commit cbb40f5
  • Test data from s3://brim-sampledata/mgbench/bench1-from-duckdb-table.parquet
  • The bench1/q3 query

This query used to fail due to prior bug #5463 which has recently been fixed. Now that we're past that, it's seeing a SEGV when I run the query against Parquet. Interestingly, I didn't see the failure when running the same query against CSUP.

$ super -version
Version: v1.18.0-167-gcbb40f53

$ SUPER_VAM=1 super -c '
from "bench1-from-duckdb-table.parquet"
| where
    machine_name=="babbage"
    and load_fifteen != null
    and load_five != null
    and load_one != null
    and mem_free != null
    and swap_free != null
    and log_time >= 2017-01-01T00:00:00Z
| summarize
    load_fifteen_avg := avg(load_fifteen),
    load_five_avg := avg (load_five),
    load_one_avg := avg (load_one),
    mem_free_avg := avg (mem_free),
    swap_free_avg := avg (swap_free)
    by hr := bucket(log_time, 1h)
| sort hr
| put _time_parts := split(strftime("%Y-%m-%d,%H", hr), ",")
| put
    dt := _time_parts[0],
    hr := uint8(_time_parts[1])
| drop _time_parts'

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x9235689]

goroutine 69 [running]:
github.com/brimdata/super.(*Context).LookupTypeRecord(0x0, {0xc008e47dc0, 0x2, 0x2})
	/Users/phil/work/super/context.go:106 +0x149
github.com/brimdata/super.(*Context).MustLookupTypeRecord(...)
	/Users/phil/work/super/context.go:151
github.com/brimdata/super/runtime/vam/expr/agg.(*avg).ResultAsPartial(0xc0016bad90, 0x0)
	/Users/phil/work/super/runtime/vam/expr/agg/avg.go:61 +0x139
github.com/brimdata/super/runtime/vam/op/summarize.(*superTable).materializeAgg(0xc026a96aa0, 0x0)
	/Users/phil/work/super/runtime/vam/op/summarize/agg.go:119 +0xf1
github.com/brimdata/super/runtime/vam/op/summarize.(*superTable).materialize(0xc026a96aa0)
	/Users/phil/work/super/runtime/vam/op/summarize/agg.go:99 +0x230
github.com/brimdata/super/runtime/vam/op/summarize.(*Summarize).next(0xc019df5e88?)
	/Users/phil/work/super/runtime/vam/op/summarize/summarize.go:130 +0x85
github.com/brimdata/super/runtime/vam/op/summarize.(*Summarize).Pull(0xc001aa9e40, 0x0?)
	/Users/phil/work/super/runtime/vam/op/summarize/summarize.go:66 +0x3a5
github.com/brimdata/super/runtime/vam/op.(*combineParent).run(0xc002172000)
	/Users/phil/work/super/runtime/vam/op/combine.go:110 +0x3f
created by github.com/brimdata/super/runtime/vam/op.(*Combine).Pull.func1 in goroutine 13
	/Users/phil/work/super/runtime/vam/op/combine.go:42 +0x35
@philrz philrz added the bug Something isn't working label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant