Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pr flow #15

Closed
wants to merge 13 commits into from
Closed
6 changes: 2 additions & 4 deletions .github/workflows/qodana.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,8 @@ jobs:
node-version: '16'
- run: npm install
- name: 'Qodana Scan'
uses: JetBrains/qodana-action@main
uses: JetBrains/qodana-action@v2024.1.5
env:
QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }}
with:
pr-mode: true
upload-result: true

upload-result: true
7 changes: 1 addition & 6 deletions js/src/carousel.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@
wrap: 'boolean',
touch: 'boolean'
}

/**
* Class definition
*/
Expand All @@ -106,13 +105,12 @@
this._indicatorsElement = SelectorEngine.findOne(SELECTOR_INDICATORS, this._element)
this._addEventListeners()
}

// changes to allow creating a PR
// Getters
static get Default() {

Check failure on line 110 in js/src/carousel.js

View workflow job for this annotation

GitHub Actions / Qodana for JS

ESLint

ESLint: Expected blank line between class members. (lines-between-class-members)

Check failure on line 110 in js/src/carousel.js

View workflow job for this annotation

GitHub Actions / Qodana for JS

ESLint

ESLint: Expected blank line between class members. (lines-between-class-members)
return Default
}

static get DefaultType() {

Check failure on line 113 in js/src/carousel.js

View workflow job for this annotation

GitHub Actions / Qodana for JS

ESLint

ESLint: Expected blank line between class members. (lines-between-class-members)

Check failure on line 113 in js/src/carousel.js

View workflow job for this annotation

GitHub Actions / Qodana for JS

ESLint

ESLint: Expected blank line between class members. (lines-between-class-members)
return DefaultType
}

Expand All @@ -126,7 +124,6 @@
}

nextWhenVisible() {
// FIXME TODO use `document.visibilityState`
// Don't call next when the page isn't visible
// or the carousel or its parent isn't visible
if (!document.hidden && isVisible(this._element)) {
Expand Down Expand Up @@ -420,8 +417,7 @@
if (![DIRECTION_RIGHT, DIRECTION_LEFT].includes(direction)) {
return direction
}

if (isRTL()) {

Check failure on line 420 in js/src/carousel.js

View workflow job for this annotation

GitHub Actions / Qodana for JS

ESLint

ESLint: Expected blank line before this statement. (padding-line-between-statements)

Check failure on line 420 in js/src/carousel.js

View workflow job for this annotation

GitHub Actions / Qodana for JS

ESLint

ESLint: Expected blank line before this statement. (padding-line-between-statements)
return direction === DIRECTION_LEFT ? ORDER_PREV : ORDER_NEXT
}

Expand All @@ -432,8 +428,7 @@
if (![ORDER_NEXT, ORDER_PREV].includes(order)) {
return order
}

if (isRTL()) {

Check failure on line 431 in js/src/carousel.js

View workflow job for this annotation

GitHub Actions / Qodana for JS

ESLint

ESLint: Expected blank line before this statement. (padding-line-between-statements)

Check failure on line 431 in js/src/carousel.js

View workflow job for this annotation

GitHub Actions / Qodana for JS

ESLint

ESLint: Expected blank line before this statement. (padding-line-between-statements)
return order === ORDER_PREV ? DIRECTION_LEFT : DIRECTION_RIGHT
}

Expand Down Expand Up @@ -527,3 +522,3 @@



2 changes: 1 addition & 1 deletion js/src/modal.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
const CLASS_NAME_FADE = 'fade'
const CLASS_NAME_SHOW = 'show'
const CLASS_NAME_STATIC = 'modal-static'

// TODO: Another

Check warning on line 40 in js/src/modal.js

View workflow job for this annotation

GitHub Actions / Qodana for JS

ESLint

ESLint: Unexpected 'todo' comment: 'TODO: Another'. (no-warning-comments)

Check warning on line 40 in js/src/modal.js

View workflow job for this annotation

GitHub Actions / Qodana for JS

ESLint

ESLint: Unexpected 'todo' comment: 'TODO: Another'. (no-warning-comments)
const OPEN_SELECTOR = '.modal.show'
const SELECTOR_DIALOG = '.modal-dialog'
const SELECTOR_MODAL_BODY = '.modal-body'
Expand Down Expand Up @@ -418,3 +418,3 @@



2 changes: 0 additions & 2 deletions qodana.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,3 @@ include:
- name: VulnerableLibrariesGlobal
- name: VulnerableLibrariesLocal
- name: Eslint

fixesStrategy: cleanup
Loading