diff --git a/.github/workflows/qodana.yml b/.github/workflows/qodana.yml index 4a0315672..45d52ddf7 100644 --- a/.github/workflows/qodana.yml +++ b/.github/workflows/qodana.yml @@ -28,10 +28,8 @@ jobs: node-version: '16' - run: npm install - name: 'Qodana Scan' - uses: JetBrains/qodana-action@main + uses: JetBrains/qodana-action@v2024.1.5 env: QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }} with: - pr-mode: true - upload-result: true - + upload-result: true \ No newline at end of file diff --git a/js/src/carousel.js b/js/src/carousel.js index 687324dc1..9ea51b8bd 100644 --- a/js/src/carousel.js +++ b/js/src/carousel.js @@ -86,7 +86,6 @@ const DefaultType = { wrap: 'boolean', touch: 'boolean' } - /** * Class definition */ @@ -106,12 +105,11 @@ class Carousel extends BaseComponent { this._indicatorsElement = SelectorEngine.findOne(SELECTOR_INDICATORS, this._element) this._addEventListeners() } - + // changes to allow creating a PR // Getters static get Default() { return Default } - static get DefaultType() { return DefaultType } @@ -126,7 +124,6 @@ class Carousel extends BaseComponent { } nextWhenVisible() { - // FIXME TODO use `document.visibilityState` // Don't call next when the page isn't visible // or the carousel or its parent isn't visible if (!document.hidden && isVisible(this._element)) { @@ -420,7 +417,6 @@ class Carousel extends BaseComponent { if (![DIRECTION_RIGHT, DIRECTION_LEFT].includes(direction)) { return direction } - if (isRTL()) { return direction === DIRECTION_LEFT ? ORDER_PREV : ORDER_NEXT } @@ -432,7 +428,6 @@ class Carousel extends BaseComponent { if (![ORDER_NEXT, ORDER_PREV].includes(order)) { return order } - if (isRTL()) { return order === ORDER_PREV ? DIRECTION_LEFT : DIRECTION_RIGHT } diff --git a/js/src/modal.js b/js/src/modal.js index 4459248f1..7ed0f5247 100644 --- a/js/src/modal.js +++ b/js/src/modal.js @@ -37,7 +37,7 @@ const CLASS_NAME_OPEN = 'modal-open' const CLASS_NAME_FADE = 'fade' const CLASS_NAME_SHOW = 'show' const CLASS_NAME_STATIC = 'modal-static' - +// TODO: Another const OPEN_SELECTOR = '.modal.show' const SELECTOR_DIALOG = '.modal-dialog' const SELECTOR_MODAL_BODY = '.modal-body' diff --git a/qodana.yaml b/qodana.yaml index da7de34bf..540c8ebf3 100644 --- a/qodana.yaml +++ b/qodana.yaml @@ -14,5 +14,3 @@ include: - name: VulnerableLibrariesGlobal - name: VulnerableLibrariesLocal - name: Eslint - -fixesStrategy: cleanup