Address Send Payment UI feedback #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdemyerebasmaz
force-pushed
the
send_payment_ui_feedback
branch
from
7d0295c to
04ed8e2
Compare
erdemyerebasmaz
force-pushed
the
send_payment_ui_feedback
branch
2 times, most recently
from
7e19b4f to
c25f25d
Compare
Remove center alignment to be consistent with LNURL payment confirmation page UI.
- Remove Currency Converter Dialog - Align Currency Converter icon to amount text - Allow users to exclude currency symbol from formatted fiat value. - Allow users to include display name to formatted fiat value.
- Allow editing label & error text style of AmountFormField - Allow formatFiat options on format - Move LnUrlPaymentLimits below error message - Add bottom padding to LnUrlPaymentLimits - Remove bottom padding from LnPaymentDescription - Reduce LNURLMetadataText max height to 120
- Display ScrollableErrorMessageWidget if there are any errors creating invoices - Allow customizing contentPadding, titleStyle & errorTextStyle of ScrollableErrorMessageWidget. - Make the error message scrollable. - Fix how LnurlWithdrawDialog looks on light theme - Make amount + description labels white
erdemyerebasmaz
force-pushed
the
send_payment_ui_feedback
branch
from
c25f25d to
7f3cd3a
Compare
erdemyerebasmaz
added a commit
that referenced
this pull request
Dec 3, 2024
* Add a placeholder image on LNURL payments * Disable "Next" & "Send" buttons if there are errors * Add a placeholder image on LN payments Remove center alignment to be consistent with LNURL payment confirmation page UI. * Add currency display name on error messages. * fix: Make SingleButtonBottomBar's enabled by default * Display Currency Converter on a bottom sheet - Remove Currency Converter Dialog - Align Currency Converter icon to amount text - Allow users to exclude currency symbol from formatted fiat value. - Allow users to include display name to formatted fiat value. * Apply font size, padding & layout changes on LNURL payment UI - Allow editing label & error text style of AmountFormField - Allow formatFiat options on format - Move LnUrlPaymentLimits below error message - Add bottom padding to LnUrlPaymentLimits - Remove bottom padding from LnPaymentDescription - Reduce LNURLMetadataText max height to 120 * Apply font size, padding & layout changes on Receive payment UIs - Display ScrollableErrorMessageWidget if there are any errors creating invoices - Allow customizing contentPadding, titleStyle & errorTextStyle of ScrollableErrorMessageWidget. - Make the error message scrollable. - Fix how LnurlWithdrawDialog looks on light theme - Make amount + description labels white * Make fiat currency chips scrollable * Update CurrencyConverterBottomSheet * Do not disable currency converter button, pop the sheet instead * Address UI Feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.