Add real-time stream endpoint #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hydra-yse
force-pushed
the
yse-rt-stream
branch
3 times, most recently
from
5630459 to
c358836
Compare
hydra-yse
force-pushed
the
yse-rt-stream
branch
from
c358836 to
5e8fc72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: It may be good to avoid broadcasting records back to the user when they were the ones to insert them - On one side, this reduces client side logic (we don't have to check for existence of already inserted records), yet on the server side, it creates the issue of keeping track of user sessions. I also think there's an advantage in receiving a "pong" back from the server whenever a record it set, just to have it as ulterior confirmation, but it is not necessary (+ removing it would save bandwidth). Let me know what you think.