You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Users can now specify the theme an image is displayed for in Markdown. Appending #gh-dark-mode-only or #gh-light-mode-only to the end of an image url will define whether it's only shown to viewers using a light or a dark GitHub theme.
Hi 👋
I've got GitHub dark mode enabled.
When I look at the README, I'm not able to view the diagrams and formulas.
When I look at the dataflow graphs directly, because they are SVGs GitHub renders them with a transparent background
Suggestions
SVG Images
Here are my suggestions for improving the visibility of the SVG images:
In the SVGs, add a white background (no more transparent backgrounds)
Create two different SVGs, one for dark mode, and another for light mode. Apply the appropriate GitHub theme context CSS class to each image.
Here's an example of a commit adding support for light/dark logos)
Formulas
For the formulas I see that they are images that are referenced using the GitHub API
https://github.com/breandan/kotlingrad/blob/0.4.5/README.md?plain=1#L113
https://github.com/breandan/kotlingrad/blob/0.4.5/README.md?plain=1#L134
Perhaps the GitHub syntax might support dark mode? https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/writing-mathematical-expressions
Here are some examples:
Inline expression (using dollars):$\mathbf{A}(\mathbf{B})$
Block using
$$
:Block using code fence
math
code fence block:They look good to me! Screenshot of the above example
The text was updated successfully, but these errors were encountered: