Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug chart.forward(): missing units #91

Open
N0talent opened this issue Jun 29, 2018 · 2 comments
Open

bug chart.forward(): missing units #91

N0talent opened this issue Jun 29, 2018 · 2 comments

Comments

@N0talent
Copy link

When i create my own Symbol data in minutes, my periodicity(R)$units is 'mins'.
as a result the function throws follwing Error:

Error in if (units == "months" && nrow(R) > 500) units <- "years" : 
  missing value where TRUE/FALSE needed

I would propose to add "mins" to the units (starting row 111 in chart.forward.R):

units <- switch(units,
                 mins="hours",
                 seconds = 'hours',
                 minutes = 'hours',
                 hours = 'days',
                 days = 'months',
                 weeks = 'years',
                 months = 'years',
                 quarters = 'years',
                 years = 'years')

I dont know if this counts as a Bug.

@braverock
Copy link
Owner

you should be able to add mins to the same row that already has minutes, or at least put them next to each other with the same style.

@jaymon0703
Copy link
Collaborator

hi @N0talent is this still an issue if you upgrade to latest version 0.16.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants