Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump express from 4.19.2 to 4.21.1 #169

Merged
merged 1 commit into from
Dec 3, 2024
Merged

chore(deps): bump express from 4.19.2 to 4.21.1 #169

merged 1 commit into from
Dec 3, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 9, 2024 •
edited
Loading

Bumps express from 4.19.2 to 4.21.1.

Release notes

Sourced from express's releases.

4.21.1

What's Changed

Full Changelog: expressjs/express@4.21.0...4.21.1

4.21.0

What's Changed

New Contributors

Full Changelog: expressjs/express@4.20.0...4.21.0

4.20.0

What's Changed

Important

  • IMPORTANT: The default depth level for parsing URL-encoded data is now 32 (previously was Infinity)
  • Remove link renderization in html while using res.redirect

Other Changes

... (truncated)

Changelog

Sourced from express's changelog.

4.21.1 / 2024-10-08

4.21.0 / 2024-09-11

4.20.0 / 2024-09-10

  • deps: [email protected]
    • Remove link renderization in html while redirecting
  • deps: [email protected]
    • Remove link renderization in html while redirecting
  • deps: [email protected]
    • add depth option to customize the depth level in the parser
    • IMPORTANT: The default depth level for parsing URL-encoded data is now 32 (previously was Infinity)
  • Remove link renderization in html while using res.redirect
  • deps: [email protected]
    • Adds support for named matching groups in the routes using a regex
    • Adds backtracking protection to parameters without regexes defined
  • deps: encodeurl@~2.0.0
    • Removes encoding of \, |, and ^ to align better with URL spec
  • Deprecate passing options.maxAge and options.expires to res.clearCookie
    • Will be ignored in v5, clearCookie will set a cookie with an expires in the past to instruct clients to delete the cookie
Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot
chore(deps): bump express from 4.19.2 to 4.21.1
64def1f 
Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.21.1.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.1/History.md)
- [Commits](expressjs/express@4.19.2...4.21.1)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 9, 2024
@dependabot dependabot bot mentioned this pull request Oct 9, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

[puLL-Merge] - expressjs/[email protected]

Description

This pull request introduces several updates and improvements to the existing CI workflows, dependency management, and documentation across the Express.js repository. The key motivations behind these changes include the modernization of CI configurations, the removal of deprecated practices, and the enhancement of security measures.

Possible Issues

  1. Backward Compatibility:

    • The refactoring of CI configurations removes the support for testing older versions of Node (0.10, 0.12) and changes the format of test matrix definitions. This could potentially affect backward compatibility or miss testing for specific Node.js versions unintentionally.
    • Deprecation notices in the res.clearCookie function could indicate breaking changes in future versions, requiring downstream applications to make sure they do not rely on deprecated options.

  2. Partial Test Coverage:

    • Some test cases for specific Node.js versions and their npm dependency resolutions are removed without corresponding replacements, leading to the risk that certain edge cases may no longer be covered.

  3. Commit History:

    • The commit message history and message consistency should be checked to ensure clarity and alignment with conventional commit messages or repository standards.

Security Hotspots

  1. Dependency Updates:

    • Regularly updating dependencies is generally good practice, but it also has the potential to introduce new vulnerabilities. Ensure the latest versions are vetted for known vulnerabilities.
    • Added CodeQL analysis should enhance code security through static analysis; however, if not correctly implemented, it might miss critical issues.

  2. Sanitization in Headers:

    • The res.location() method now includes modifications to reduce XSS vulnerabilities by not rendering redirects using HTML anchor tags. While this mitigation is beneficial, careful auditing is needed to ensure it avoids introducing broader issues.
Changes

Changes

.github/workflows/ci.yml

  • CI Workflow Modernization:
    • Replace support for Node.js 0.10, 0.12, etc., by adding versions up to Node.js 22.x.
    • Simplified steps for setting up Node.js and npm, and grouped into logical job steps.
    • Separated lint and test CI jobs to improve workflow readability and efficiency.

.github/workflows/codeql.yml

  • New Workflow File:
    • Adds CodeQL static analysis workflows for security scanning, scheduled to run weekly.

.github/workflows/iojs.yml

  • New Test Workflow for io.js:
    • Dedicated workflow for testing legacy io.js versions 1.8, 2.5, 3.3.

.gitignore & .npmrc

  • Added npm-shrinkwrap.json to .gitignore.
  • Created a .npmrc file to disable package-lock file generation.

Code-Of-Conduct.md, Contributing.md, Release-Process.md, Security.md, Triager-Guide.md

  • Documentation Updates:
    • Minor corrections and additions related to project maintenance and community guidelines.
    • Distinguish active captains for project submodules.
    • Highlight pre-release versions as unstable and expanded threat model section in Security.md.

History.md

  • Version History:
    • Added entries documenting recent releases including 4.21.1.

Readme.md

  • Enhanced README:
    • Added sections, badges, and structured table of contents to improve readability and navigation.
    • Included details about the technical committee (TC) and triagers.

appveyor.yml

  • Appveyor Updates:
    • Added support for testing Node.js version 22.0.

lib/response.js

  • Deprecation and Code Refactors:
    • Removed urlParse import.
    • Added deprecation warnings for res.clearCookie options.
    • Simplified logic in res.location and res.redirect.

package.json

  • Dependency Updates:
    • Incremented version to 4.21.1.
    • Updated dependencies such as body-parser, cookie, finalhandler, path-to-regexp with additional features or fixes.
    • Expanded the scripts section to improve test command execution.

test/*

  • Improved Testing:
    • Added tests for edge cases and recognized new behavior/headers.
    • Updated tests to align with new changes in encoding logic, depreciation notices, and other functionality changes.

Overall, this PR is a comprehensive update that modernizes the codebase, enhances security practices, and improves documentation clarity. It should be thoroughly tested for backward compatibility and reviewed for any unintentional side effects.

@Thomasmbot
Copy link

Uploading IMG_20241012_200947_997.jpg…
Me

@Thomasmbot
Copy link

Uploading 20241013_051935(1).jpg…

@Thomasmbot
Copy link

Me again

@diracdeltas diracdeltas requested a review from onyb December 2, 2024 20:31
@onyb onyb merged commit 6615adc into main Dec 3, 2024
5 checks passed
@onyb onyb deleted the dependabot/npm_and_yarn/express-4.21.1 branch December 3, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onyb onyb onyb approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file puLL-Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thomasmbot @onyb