Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[ads] Unify iOS kBraveNTPBrandedWallpaper #8701

Closed
tmancey opened this issue Jan 25, 2024 · 1 comment · Fixed by #8702
Closed

[ads] Unify iOS kBraveNTPBrandedWallpaper #8701

tmancey opened this issue Jan 25, 2024 · 1 comment · Fixed by #8702
Assignees
@tmancey
Labels
enhancement QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.62

Comments

@tmancey
Copy link
Collaborator

tmancey commented Jan 25, 2024

Corresponding changes to brave/brave-browser#35522
@tmancey tmancey self-assigned this Jan 25, 2024
@tmancey tmancey mentioned this issue Jan 25, 2024
Merged
11 tasks
@iccub iccub added this to the 1.62 milestone Jan 30, 2024
@tmancey tmancey mentioned this issue Jan 31, 2024
Closed
This was referenced Feb 6, 2024
Open
Closed
@hffvld
Copy link
Collaborator

hffvld commented Feb 6, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.4 Beta
Brave build: 1.62 (24.2.6.11)
BraveCore: 1.62.158 (121.0.6167.139)

Filed follow-up issue #8740

STEPS:

  1. Followed the steps from [ads] Unify iOS kBraveNTPBrandedWallpaper #8702 (comment)
  2. And [ads] Unify iOS kBraveNTPBrandedWallpaper feature brave-browser#35522 (comment)

ACTUAL RESULTS:

  • Verified that NTP SI is shown on 2nd NTP for BraveNTPBrandedWallpaper/initial_count_to_branded_wallpaper
  • Verified that NTP SI must be shown on every 3rd NTP for BraveNTPBrandedWallpaper/count_to_branded_wallpaper but observed it on every 4th NTP

Rewards opt-out

2024-02-06_14-38-09.mp4

Rewards opt-in

2024-02-06_15-08-24.mp4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tmancey tmancey

Labels
enhancement QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.62
Development

Successfully merging a pull request may close this issue.

[ads] Unify iOS kBraveNTPBrandedWallpaper brave/brave-ios
4 participants
@tmancey @iccub @Uni-verse @hffvld