Buttons loading states / functionality is broken (IUButtonConfiguration)

[soner-yuksel]

Description:

UIButton deprecated various properties and this is causing warning all over the application and in addition this situation is causing some UI discrepancies on some button functionality on the browser.

The major problem is button that has loading state. The addsubview still working on UIButton however dynamically changing subview properties is totally not functioning.

So any custom button that has loading indicator added as subview and loading state is changed accordingly is broken. No loading indicator is shown or functioning. This effects mainly BraveButton class and its functionality and subclasses like ActionButton.

An example to this can be given as when Open search engine is added the open search button OpenSearchEngineButton is not showing its loading state.

Actual result:

Loading states are broken and some other functionality should be thoroughly checked in the app where deprecated button properties and other things are used. Also all the warning related with UIButton generation should be wiped and cleaned.

Expected result:

All functionality should be working properly and and buttons should be converted to using UIButton configuration.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

• Can you reproduce this issue with the most recent build from TestFlight? Yes
• Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
• Can you reproduce this issue with the current build from AppStore? Yes

Device details:

Any

Website problems only:

• did you check with Brave Shields down?
• did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information