Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skus sdk native-client - add body to httpclient request for skus (uplift to 1.46.x) #15833

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 7, 2022

Uplift of #15785
Resolves brave/brave-browser#26523

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner November 7, 2022 20:31
@brave-builds brave-builds self-assigned this Nov 7, 2022
@brave-builds brave-builds added this to the 1.46.x - Beta milestone Nov 7, 2022
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.47.56 Chromium: 107.0.5304.91 (Official Build) nightly (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 11.7.1 (Build 20G918)

Steps:

  1. launched Brave with --vmodule="*/skus/*"=1 --enable-logging=stderr --v=0
  2. opened brave://flags
  3. set brave://flags/#brave-vpn to Enabled
  4. set brave://flags/#skus-sdk to Enabled (not necessary, as it's now Enabled by default, force of habit)
  5. relaunched Brave (with commandline intact)
  6. loaded account.bravesoftware.com
  7. entered username/password from 1PW
  8. used a throwaway email address from mailinator.com - [email protected]
  9. clicked Get login link button
  10. clicked on the link in the email I got
  11. clicked Browse plans
  12. scrolled down
  13. clicked Buy now for Brave VPN Subscription
  14. completed purchase through Stripe (https://stripe.com/docs/testing#testing-interactively)

Confirmed I was able to purchase, get issued credentials for, and use the Brave VPN connection 👍

Screen Shot 2022-11-09 at 1 06 44 PM

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.46.x approved 👍 QA has verified the PR on Nightly as per #15833 (comment).

@kjozwiak kjozwiak merged commit 7abcf69 into 1.46.x Nov 9, 2022
@kjozwiak kjozwiak deleted the pr15785_bh-skus-request-fetch-fix_1.46.x branch November 9, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants