Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Keep in dock option to first run dialog and settings (uplift to 1.46.x) #15789

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Add Keep in dock option to first run dialog and settings (uplift to 1.46.x) #15789

merged 1 commit into from
Nov 4, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 3, 2022 •
edited by kjozwiak
Loading

Uplift of #14714
fix brave/brave-browser#24055

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner November 3, 2022 23:08
@brave-builds brave-builds self-assigned this Nov 3, 2022
@brave-builds brave-builds added this to the 1.46.x - Beta milestone Nov 3, 2022
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false labels Nov 3, 2022
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

1 similar comment
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

kjozwiak
kjozwiak approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.46.x approved 👍 QA has verified the PR on Nightly as per #14714 (comment).

@kjozwiak kjozwiak merged commit 0600a73 into 1.46.x Nov 4, 2022
@kjozwiak kjozwiak deleted the pr14714_add_to_dock_when_brave_is_default_1.46.x branch November 4, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Milestone
1.46.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases