Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update response handling logic for conversion of std::string to std::vector<uint8_t> (uplift to 1.39.x) #13600

Closed
wants to merge 1 commit into from
Closed

Update response handling logic for conversion of std::string to std::vector<uint8_t> (uplift to 1.39.x) #13600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions components/skus/browser/skus_url_loader_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,8 @@ void SkusUrlLoaderImpl::OnFetchComplete(
bool success = (error_code == net::OK && response_code == net::HTTP_OK);

std::vector<uint8_t> body_bytes;
if (response_body) {
const uint8_t* begin =
reinterpret_cast<const uint8_t*>(response_body->data());
const uint8_t* end = begin + response_body->size();
body_bytes.assign(begin, end);
if (response_body && response_body->size()) {
body_bytes.assign(response_body->begin(), response_body->end());
}

skus::HttpResponse resp = {
Expand Down