Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update response handling logic for conversion of std::string to std::vector<uint8_t> (uplift to 1.39.x) #13600

Closed
wants to merge 1 commit into from
Closed

Update response handling logic for conversion of std::string to std::vector<uint8_t> (uplift to 1.39.x) #13600

wants to merge 1 commit into from

Conversation

brave-builds
Copy link
Collaborator

Uplift of #13555

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team June 3, 2022 16:10
@brave-builds brave-builds self-assigned this Jun 3, 2022
@brave-builds brave-builds added this to the 1.39.x - Release #3 milestone Jun 3, 2022
@bsclifton
Copy link
Member

Closing as this did not fix brave/brave-browser#23140 ☹️

@bsclifton bsclifton closed this Jun 6, 2022
@bsclifton bsclifton deleted the pr13555_bsc-fix-premium-login-crash_1.39.x branch June 6, 2022 19:07
@kjozwiak kjozwiak removed the request for review from a team June 6, 2022 22:02
@kjozwiak kjozwiak removed this from the 1.39.x - Release #3 milestone Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @bsclifton @kjozwiak @brave-browser-releases