Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update response handling logic for conversion of std::string to std::vector<uint8_t> #13555

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Jun 1, 2022

Linux may not have been null terminating data(). Also updates to add size check.

Potential fix for brave/brave-browser#23140

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

I can't reproduce the crash locally when trying to login; but the fix attempted makes sense when looking at the stack trace

@bsclifton bsclifton requested a review from iefremov June 1, 2022 07:44
@bsclifton bsclifton self-assigned this Jun 1, 2022
@bsclifton bsclifton force-pushed the bsc-fix-premium-login-crash branch from 89e457a to 218aa55 Compare June 1, 2022 08:29
@bsclifton bsclifton changed the title Guards around response handling logic Update response handling logic to use .c_str() instead of .data() Jun 1, 2022
Linux may not have been null terminating data(). Also updates to add size check.

Potential fix for brave/brave-browser#23140
@bsclifton bsclifton force-pushed the bsc-fix-premium-login-crash branch from 218aa55 to 6ac3903 Compare June 1, 2022 16:55
@bsclifton bsclifton changed the title Update response handling logic to use .c_str() instead of .data() Update response handling logic for conversion of string to std::vector<uint8_t> Jun 1, 2022
@bsclifton bsclifton changed the title Update response handling logic for conversion of string to std::vector<uint8_t> Update response handling logic for conversion of std::string to std::vector<uint8_t> Jun 1, 2022
@bsclifton
Copy link
Member Author

Merge pending testing to make sure it solves the issue 😄 @iefremov to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants