Skip to content

Commit

Permalink
Fix shields setting in private is weird
Browse files Browse the repository at this point in the history
When content setting's IncognitoBehavior is INHERIT_IF_LESS_PERMISSIVe,
normal profiles setting is modified when incognito profile's content settings
are initialized. Because of this behavior, sometimes shields are off and shields's
default configurations are different with normal window.
With INHERIT_IN_INCOGNITO, private windows uses normal windows' configuration w/o
modification.
  • Loading branch information
simonhong committed Dec 15, 2018
1 parent 14706a8 commit 41ba6d4
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ void ContentSettingsRegistry::BraveInit() {
CONTENT_SETTING_DETECT_IMPORTANT_CONTENT),
WebsiteSettingsInfo::SINGLE_ORIGIN_WITH_EMBEDDED_EXCEPTIONS_SCOPE,
WebsiteSettingsRegistry::DESKTOP,
ContentSettingsInfo::INHERIT_IF_LESS_PERMISSIVE,
ContentSettingsInfo::INHERIT_IN_INCOGNITO,
ContentSettingsInfo::EPHEMERAL);
}

Expand Down

0 comments on commit 41ba6d4

Please sign in to comment.