Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to select Google as default SE for NTP search widget when 3 or more SEs are in the list #42469

Open
2 of 6 tasks
LaurenWags opened this issue Nov 22, 2024 · 1 comment
Assignees
Labels
feature/new-tab feature/search OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes regression

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #41789

Unable to select Google as SE for NTP search widget when it's the first of 3 or more search engines.

Works fine on 1.73.91 (current release).

Steps to reproduce

  1. Install 1.74.10
  2. Close/relaunch to pull griffin
  3. Open NTP
  4. Click on Brave logo of search widget
  5. Select "Customize List"
  6. Select (in order): DDG, Google, Bing
  7. De-select Brave
  8. Close customize dashboard modal
  9. Click on DDG logo on search widget
  10. Click on Google from list ---> Google is not selected, remains DDG
  11. Try selecting Bing from the list, this works fine
  12. Now try selecting Google again --> Google is not selected but it switches to DDG

I considered maybe it was a problem with the first SE in the list, but if I use 3 different SEs (ex. DDG, Bing, Qwant), all 3 are selectable.

Actual result

Screen.Recording.2024-11-22.at.4.05.05.PM.mov

Expected result

Google should be able to be chosen like any other SE in the list. Here's an example with 3 different SEs and all can be chosen without issue:

Screen.Recording.2024-11-22.at.4.11.05.PM.mov

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.74.10 Chromium: 131.0.6778.85 (Official Build) beta (x86_64)
Revision bdff9e7d7314280ddbce1c3ada3abee4ce4a3b32
OS macOS Version 14.7.1 (Build 23H222)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc @rebron @IanKrieger @brave/qa-team

@MadhaviSeelam
Copy link

Reproduced this issue. Initially when I tested this I may have seen but I couldn't reproduce it because it appears to be order of selection matters.,

Select DDG or any other SE (Qwant)
Select Google
Will encounter above issue

Select Google SE first in the Dashboard
then select any other SE (DDG, Qwant etc.)
Switch between of them
No issues selecting multiple SE

2024-11-29_14h33_11.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/new-tab feature/search OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes regression
Projects
Status: No status
Development

No branches or pull requests

4 participants