Remove the unnecessary NoDestructor in unstoppable_domains::GetRecordKeys
#42453
Assignees
Labels
dev-concern
feature/web3/wallet/core
feature/web3/wallet
Integrating Ethereum+ wallet support
OS/Desktop
QA/No
release-notes/exclude
Milestone
Comments
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Nov 22, 2024
This function has been returning a vector of strings, to be used by `GetMany`, and therefore a `NoDestructor` instance is needed. However, the only reason why this has to be a vector of strings is because in the end `EncodeStringArray` requires a vector of strings. This PR changes `EncodeStringArray` to take spans of strings and of string views. This will allows to convert the keys into a `constexpr` value, and avoid the use of `NoDestructor`. In a follow up PR, additional callsites of `EncodeStringArray` may be migrated to the `string_view` variant. This is a follow up of these PRs: #26683 #26688 Resolves brave/brave-browser#42453
24 tasks
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Nov 22, 2024
This function has been returning a vector of strings, to be used by `GetMany`, and therefore a `NoDestructor` instance is needed. However, the only reason why this has to be a vector of strings is because in the end `EncodeStringArray` requires a vector of strings. This PR changes `EncodeStringArray` to take spans of strings and of string views. This will allows to convert the keys into a `constexpr` value, and avoid the use of `NoDestructor`. In a follow up PR, additional callsites of `EncodeStringArray` may be migrated to the `string_view` variant. This is a follow up of these PRs: #26683 #26688 Resolves brave/brave-browser#42453
brave-builds
added
feature/web3/wallet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
That static should be a simple constexpr constant.
The text was updated successfully, but these errors were encountered: