Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vpn paywall discount text behavior #42105

Closed
3 of 6 tasks
deeppandya opened this issue Nov 5, 2024 · 2 comments · Fixed by brave/brave-core#26377
Closed
3 of 6 tasks

Update vpn paywall discount text behavior #42105

deeppandya opened this issue Nov 5, 2024 · 2 comments · Fixed by brave/brave-core#26377
Assignees
Milestone

Comments

@deeppandya
Copy link

Description

Renews annually has html tags that's should not be shown.

Steps to reproduce

  1. Install fresh profile
  2. Go to Brave VPN Paywall page

Actual result

Image

Expected result

Html tags shouldn't be shown while waiting for the response from play services.

Reproduces how often

Easily reproduced

Brave version

release channel 1.71.121

Device

  • Brand/model: Pixel 7pro
  • Android version: 15

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@deeppandya deeppandya added the OS/Android Fixes related to Android browser functionality label Nov 5, 2024
@deeppandya deeppandya self-assigned this Nov 5, 2024
@deeppandya
Copy link
Author

CC @srirambv

@brave-builds brave-builds added this to the 1.73.x - Nightly milestone Nov 6, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 22, 2024
@hffvld
Copy link
Contributor

hffvld commented Nov 22, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 15 AP41.240925.009 release-keys
Brave build: 1.74.8
Chromium: 131.0.6778.69 (Official Build) beta (64-bit) 

STEPS:

  1. Follow the STR/TP from Update vpn paywall discount text behavior #42105 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that HTML tags are not exposed on the VPN paywall.

1 2
1 2

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants