Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PWA]: Revert to the old Create shortcut behavior with the option to open the site as a window #42057

Closed
fallaciousreasoning opened this issue Nov 4, 2024 · 1 comment · Fixed by brave/brave-core#26349
Closed

[PWA]: Revert to the old Create shortcut behavior with the option to open the site as a window #42057

fallaciousreasoning opened this issue Nov 4, 2024 · 1 comment · Fixed by brave/brave-core#26349
Labels
feature/pwa OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.74.x - Beta

Comments

@fallaciousreasoning
Copy link

  1. Create a shortcut for a page which does not have a PWA (ie no Install <site> menu entry)
  2. There should be an option on the dialog to Open as window
@fallaciousreasoning fallaciousreasoning mentioned this issue Nov 4, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.73.x - Nightly milestone Nov 5, 2024
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.74.11 Chromium: 131.0.6778.85 (Official Build) beta (64-bit)
-- | --
Revision | c777fe11bc7afc00156e58af64a6a5bb9559da7d
OS | Windows 11 Version 24H2 (Build 26100.2314)

Issue was tested as part of #40702 (comment). Attaching a screenshot here

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/pwa OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.74.x - Beta
Development

Successfully merging a pull request may close this issue.

[PWA]: Create PWAs, not shortcuts brave/brave-core
3 participants
@fallaciousreasoning @brave-builds @MadhaviSeelam